Repository navigation
Conversation
WebHostLib/markdown.py: rewrite image URLs by walking the finished token tree in ImgUrlRewriteInlineParser.__call__. mistune 3.4 builds images when the closing bracket is parsed, so the parse_link override no longer saw them. test/webhost/test_markdown.py: cover images inside links, emphasis and reference links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Image URL rewriting for rendered docs in
WebHostLib/markdown.py.Description
parse_linkoverride no longer saw them and relative doc images kept their unrewritten URLs.ImgUrlRewriteInlineParsernow rewrites image URLs on the finished token tree, which also reaches images nested inside links and emphasis. Themistune>=3.3.0,<4range is unchanged.