Repository navigation
feat(generate): tick alternating glyphs while long fill loops run - #193
Merged
Merged
Conversation
BaseUtils.py: ProgressTicker prints one alternating glyph per pass of a slow loop once the console has been quiet for 2 s; init_logging hands it the console stream and ends its line before each record. Fill.py: tick in the fill_restrictive placement and swap loops, remaining_fill, and the progression balancing sphere and candidate loops. BaseClasses.py: tick in the playthrough sphere, cull and precollected-item loops. test/utils/test_progress_ticker.py: throttle, alternation, line ending and unusable-stream cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Generate prints liveness glyphs while the fill, progression balancing and playthrough loops run.
Description
Utils.progress_ticker.tick()runs once per pass of those loops and prints one alternating △/▲ on a single console line whenever output has been quiet for 2 s.init_logginghands the ticker its console stream and ends the glyph line before each record; withoutinit_logging(the webhost) nothing prints.