Repository navigation
fix(frozen,server): ship rule_builder.cached_world and let --admin-password outrank saves - #191
Merged
Merged
Conversation
setup.py: Add rule_builder to the cx_Freeze packages list so rule_builder.cached_world ships in frozen builds; only externally installed worlds import it.
MultiServer.py: Record whether --admin-password was given and reapply it after init_save; host.yaml's default still yields to the save. test/programs/test_server_password_alias.py: Drive main() against a save written with another password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Two fixes for frozen builds and local hosting: a module the freeze left out, and an admin password the server discarded.
Description
setup.py:rule_builderis in the cx_Freeze packages list again. Upstream'sincludes: ["rule_builder.cached_world"]was dropped in the no-worldssetup.pyrewrite, and only out-of-tree worlds import that module, so frozen builds failed to load worlds such as Hollow Knight: Silksong withNo module named 'rule_builder.cached_world'.MultiServer.py: an explicit--admin-password(what the launcher's Start/Host dialog passes) now outranks theadmin_passworda save restores; host.yaml's default still yields to the save. Re-hosting a seed whose save had no admin password used to leave remote administration disabled. Upstream's--server_passwordhas the same ordering.setup.pychange has not been run through a macOS freeze yet.