Repository navigation
fix(installer): launch outside Setup and report a broken worlds venv - #187
Merged
Merged
Conversation
.github/actions/install-inno-setup/action.yml: New action that installs a pinned, SHA-256 checked Inno Setup 7.1.0 in portable mode and exports ISCC. .github/workflows/build-release-test.yml: Install Inno through install-inno-setup instead of choco. Build with --no-signing --quiet-progress --messages-jsonl and re-emit compiler messages as annotations. .github/workflows/release.yml: Same Inno install and build changes. inno_setup.iss: Start the launcher through explorer.exe after install and on updater relaunch so it does not inherit the Setup RedirectionGuard. ModuleUpdate.py: Move the venv bootstrap into _bootstrap_worlds_venv(). Keep the uv error in worlds_venv_error, disable installs on failure, and never pass the frozen exe as --python. MultiWorld.py: Show a "Game installs are broken" dialog when the worlds venv could not be created, and share the frontend wait loop. test/general/test_world_install.py: Cover the venv bootstrap failure, exception and success paths. test/general/test_launcher_stack.py: Cover the explorer launch entries and the broken-venv dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Windows installer launch and the worlds-venv bootstrap: a launcher started by Setup could not use a healthy worlds venv, and every later install failed with a misleading error.
Description
[Run]entries now start the launcher throughexplorer.exe.ModuleUpdatekeeps theuv venverror inworlds_venv_error, disables installs while it is set, and no longer passes the frozen launcher exe to uv as--python..github/actions/install-inno-setup(Chocolatey and the runner image stop at 6.7.1) and builds with--no-signing --quiet-progress --messages-jsonl, re-emitting compiler messages as annotations.