Conversation
Move duplicated column/row selection of imputation_zeros and imputation_half_minimum into _select_imputation_targets. Warn on unknown on_rows labels in both and drop deprecated to_numeric(errors="ignore"). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
...
List of changes proposed in this PR (pull-request)
Checks
In case you add a new module or update one, please check the following tasks:
__init__.pyin the new folder, so thatthey are available when the subpackage is imported.
src/acore/typesfolder.Optimal is to have only one output schema of results per subpackage or module.
datafolder, or reuse an existing one for testingdocs/api_examples_modulefolder with that dataindex.mdfile in thedocsfolder with the new example/testsfolder with the name of the subpackage or moduleusing pytest or unittests to test your new functionality.