Skip to content

Refactor imputation module - #92

Draft
enryH wants to merge 3 commits into
mainfrom
refactor_imputation_module
Draft

enryH wants to merge 3 commits into
mainfrom
refactor_imputation_module

Conversation

@enryH

@enryH enryH commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #

...

List of changes proposed in this PR (pull-request)

  • ...
  • ...

Checks

In case you add a new module or update one, please check the following tasks:

  • The folder names defines the name of the subpackage (module)
  • Add the user-facing functions to the __init__.py in the new folder, so that
    they are available when the subpackage is imported.
  • Create Pandera schema in a file with subpackage name in the src/acore/types folder.
    Optimal is to have only one output schema of results per subpackage or module.
  • Add a relatively small and public dataset to the data folder, or reuse an existing one for testing
  • Create an api example jupyter notebook in the docs/api_examples_module folder with that data
  • Use jupytext to sync the Jupyter notebook with a Python script
  • Update index.md file in the docs folder with the new example
  • Create test script in the /tests folder with the name of the subpackage or module
    using pytest or unittests to test your new functionality.

enryH and others added 3 commits September 30, 2026 11:23
Move duplicated column/row selection of imputation_zeros and
imputation_half_minimum into _select_imputation_targets. Warn on unknown
on_rows labels in both and drop deprecated to_numeric(errors="ignore").

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant