Cloud POS order tips#64
Open
zulquer wants to merge 4 commits into
Open
Conversation
Add models and wiring to support tip information in order requests for POS/Cloud POS. Introduces Tip and AmountDetails components, exposes them in components.__init__, and adds amount_details field and add_amount_details method to OrderRequest. Includes example script and README documentation showing tip serialization (amounts in smallest currency unit), and updates/adds unit and integration tests to cover serialization and behavior. Tip.add_amount accepts either an Amount value object or an int.
Add copyright, license and disclaimer headers to example, component and test files; clarify README text for amount_details serialization; and change OrderRequest.amount type from Optional[str] to Optional[int] to reflect numeric amounts. Tests were updated with headers only.
Ensure transport exceptions raised before a response is assigned are not masked as HTTP 5xx errors. Initialize response = None and guard the 5xx handling with a response is not None check. Add a _FailingTransport stub and test_create_request_propagates_transport_failure_without_response to verify ConnectionError from the transport bubbles up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 92.61% 92.76% +0.14%
==========================================
Files 180 182 +2
Lines 3331 3357 +26
==========================================
+ Hits 3085 3114 +29
+ Misses 246 243 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.