Open
Conversation
GetOrbitalStateVectorsAtUT() is particularly whack in the way that it applies the inverse rotation constructed at a future time via using Planetarium.ZupAtT(). That means that for the most part it is only useful for constructing values which can only be compared to other vectors constructed at the same time. This bug only occurs when the vessel is below the inverse rotation threshold, though, so most of the time works fine when there's no rotation being applied. The changes to RightHandedStateVectorsAtUT mean that we apply our own rotation in the current frames rotation to get RH rotating vectors. This is consistent with the old API, but should probably be retired and everything migrated to RH non-rotating vectors now that I can see how to get them out of the API correctly. This may also fix other bugs in consumers of the underlying maneuvers class (e.g. rendezvous autopilot, etc). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
These use GetOrbitalStateVectorsAtUT() which is problematic, they don't call Init() and have other sketchy looking behavior and nothing has used them in awhile. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
This fixes a (now) obvious bug in the transfer planner in the use of GetOrbitalStateVectorsAtUT(), although it seems to only affect debug log output. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Avoids using the KSP.IO.File.Exist<T>() API that walks the loaded assemblies and throws, looking for the path to the assembly with the type T. The MuUtils helper replicates the side effect of this API of creating the directory. Since we construct the path afterwards anyway to load the file the only reason I can see for the reflection-driven-API is for that side-effect, and to cause weird bugs if someone ever moves the DLL location around and makes the two APIs start to disagree.
fixes #1611 by just creating a lazy accessor Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
somehow i had convinced myself the stock fairing was a moduledecouple when it is actually not.
This makes stock fairings work correctly when they also have a payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet more bug stomping.