KKMaterial migration by brownd1978 · Pull Request #1833 · Mu2e/Offline

brownd1978 · 2026-05-16T22:27:54Z

This PR moves KKMaterial from Mu2eKinKal to GeometryService. Previously, each client created its own instance of KKMaterial, which required duplicate configuration. Now there's one instance, with a single configuration in standard_services. This PR makes no functional change.
There are knockon changes required in Production, EventNtuple and mu2e-trig-config due to configuration and link dependency changes.
This PR is a precursor to creating material objects for KinKal extrapolation.

FNALbuild · 2026-05-16T22:28:24Z

Hi @brownd1978,
You have proposed changes to files in these packages:

Mu2eG4
ProductionTargetGeom
fcl
GeometryService
Mu2eKinKal
RecoDataProducts
TrackerConditions
CalPatRec
KinKalGeom

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild · 2026-05-16T22:37:45Z

☔ The build tests failed for 94b1baf.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `94b1baf` at `23fc715`
build (prof)	✅	Log file. Build time: 04 min 10 sec
ceSimReco	❌	Log file. Return Code 90.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	❌	Log file. Return Code 90.
cosmicOffSpill	❌	Log file. Return Code 90.
ceSteps	✅	Log file.
ceDigi	❌	Log file. Return Code 90.
muDauSteps	✅	Log file.
ceMix	❌	Log file. Return Code 90.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	❌	Log file. Return Code 2.
check_cmake	✅	Log file.
FIXME, TODO	➡️	TODO (25) FIXME (9) in 25 files
clang-tidy	➡️	18 errors 541 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

michaelmackenzie · 2026-05-16T22:44:07Z

@FNALbuild run build test with Mu2e/mu2e-trig-config#162

FNALbuild · 2026-05-16T22:44:36Z

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

FNALbuild · 2026-05-16T22:57:26Z

☔ The build tests failed for 94b1baf.

Test	Result	Details
test with	✅	Included Mu2e/mu2e-trig-config#162 @ 6afce9ff8437c0ba98d1d9a2d1c17f3cad00ae28 by merge
merge	✅	Merged `94b1baf` at `23fc715`
build (prof)	✅	Log file. Build time: 04 min 10 sec
ceSimReco	❌	Log file. Return Code 90.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	❌	Log file. Return Code 90.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	➡️	TODO (25) FIXME (9) in 25 files
clang-tidy	➡️	18 errors 541 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

brownd1978 · 2026-05-17T00:47:27Z

Thanks Michael!

brownd1978 · 2026-05-17T00:49:20Z

@FNALbuild run build test with Mu2e/mu2e-trig-config#162, Mu2e/Production#541

FNALbuild · 2026-05-17T00:49:44Z

⌛ The following tests have been triggered for 94b1baf: build (Build queue - API unavailable)

FNALbuild · 2026-05-17T01:02:36Z

☀️ The build tests passed at 94b1baf.

Test	Result	Details
test with	✅	Included Mu2e/mu2e-trig-config#162 @ 6afce9ff8437c0ba98d1d9a2d1c17f3cad00ae28 by merge
test with	✅	Included Mu2e/Production#541 @ 4689cfbcfa3c98e65bb65957dd294edabc993902 by merge
merge	✅	Merged `94b1baf` at `23fc715`
build (prof)	✅	Log file. Build time: 04 min 08 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	➡️	TODO (25) FIXME (9) in 25 files
clang-tidy	➡️	18 errors 541 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 94b1baf after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

rlcee · 2026-05-18T14:14:14Z

        inputFile           : "Offline/Mu2eG4/geom/geom_common.txt"
        bFieldFile          : "Offline/Mu2eG4/geom/bfgeom_v01.txt"
        simulatedDetector   : { tool_type: "Mu2e" }
+        KinKalMaterial : {


this seems like a good place to use @table from a KK prolog since the content is all static and relevant only to KK, it should be located in a KK directory

I debated this mentally as well. These parameters are only used in KinKal but they describe the general detector.
Currently we describe the entire detector geometry for simulation and reconstruction with Mu2eG4/geom. This breaks the design intent that GeometryService be agnostic, since we can't run reconstruction without Mu2eG4 (and its Geant4 dependency) in the release/path. A truely agnostic solution is to put base geometry and material definitions in a neutral package. That would be a natural place then to put this KinKal material config.

For now I'll follow this suggestion, and create an issue for the bigger issue.

rlcee · 2026-05-18T14:40:51Z


 namespace mu2e {
-  class KKMaterial {
+  class KKMaterial : public MatEnv::FileFinderInterface, public Detector, public ProditionsEntity {


I don't think this needs to be a proditionsentity unless it will have run dependence within one geometry file config, like alignment.

I was following an existing pattern (Tracker) without thinking. Since we've firmly committed to not allowing multiple base geometries in 1 job I'll remove ProditionsEntity here and in KKGeom.

brownd1978 · 2026-05-18T18:15:37Z

@FNALbuild run build test with Mu2e/mu2e-trig-config#162, Mu2e/Production#541

FNALbuild · 2026-05-18T18:16:03Z

⌛ The following tests have been triggered for 9edc8a0: build (Build queue - API unavailable)

FNALbuild · 2026-05-18T18:29:24Z

☀️ The build tests passed at 9edc8a0.

Test	Result	Details
test with	✅	Included Mu2e/mu2e-trig-config#162 @ 6afce9ff8437c0ba98d1d9a2d1c17f3cad00ae28 by merge
test with	✅	Included Mu2e/Production#541 @ 4689cfbcfa3c98e65bb65957dd294edabc993902 by merge
merge	✅	Merged `9edc8a0` at `23fc715`
build (prof)	✅	Log file. Build time: 04 min 18 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	➡️	TODO (25) FIXME (9) in 26 files
clang-tidy	➡️	18 errors 537 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 9edc8a0 after being merged into the base branch at 23fc715.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

brownd1978 · 2026-05-19T19:04:15Z

@rlcee I believe I addressed your issues, can you approve or provide further feedback?

rlcee

Thanks

brownd1978 added 9 commits May 11, 2026 16:01

Add materials for DS

f2f8899

Prep for moving KKMaterial to KinKalGeom

bfc1fd9

Fix bugs

d792d4d

Consolidate interfaces

3c30b9c

Move KKMaterial and KKStrawMaterial to KinKalGeom

3477b3e

Put KKMaterial into GeometryService

e3dc0e0

Convert to using KKMaterial from GeometryService

3dbe697

Fix

0004c25

Fix whitespace errors in others files

94b1baf

brownd1978 requested a review from bonventre May 16, 2026 22:27

FNALbuild added build pending build running and removed build pending labels May 16, 2026

This was referenced May 16, 2026

Add new dependency from GeometryService Mu2e/EventNtuple#368

Merged

KKMaterial from GeometryService migration Mu2e/mu2e-trig-config#162

Open

KKMaterial from GeometryService migration Mu2e/Production#541

Open

brownd1978 requested a review from rlcee May 16, 2026 22:36

FNALbuild added build failed and removed build running labels May 16, 2026

FNALbuild added build pending and removed build failed labels May 16, 2026

FNALbuild added build running and removed build pending labels May 16, 2026

FNALbuild added build failed and removed build running labels May 16, 2026

FNALbuild added build pending build running and removed build failed build pending labels May 17, 2026

FNALbuild added build finished and removed build running labels May 17, 2026

rlcee reviewed May 18, 2026

View reviewed changes

Remove unneeded ProditionsEntity dependency. Cleanup fcl

9edc8a0

FNALbuild added build pending and removed build finished labels May 18, 2026

FNALbuild added build running and removed build pending labels May 18, 2026

FNALbuild added build finished and removed build running labels May 18, 2026

bonventre approved these changes May 18, 2026

View reviewed changes

rlcee approved these changes May 19, 2026

View reviewed changes

Conversation

brownd1978 commented May 16, 2026

Uh oh!

FNALbuild commented May 16, 2026

Uh oh!

FNALbuild commented May 16, 2026

Uh oh!

michaelmackenzie commented May 16, 2026

Uh oh!

FNALbuild commented May 16, 2026

Uh oh!

FNALbuild commented May 16, 2026

Uh oh!

brownd1978 commented May 17, 2026

Uh oh!

brownd1978 commented May 17, 2026

Uh oh!

FNALbuild commented May 17, 2026

Uh oh!

FNALbuild commented May 17, 2026

Uh oh!

rlcee May 18, 2026

Choose a reason for hiding this comment

Uh oh!

brownd1978 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rlcee May 18, 2026

Choose a reason for hiding this comment

Uh oh!

brownd1978 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

brownd1978 commented May 18, 2026

Uh oh!

FNALbuild commented May 18, 2026

Uh oh!

FNALbuild commented May 18, 2026

Uh oh!

brownd1978 commented May 19, 2026

Uh oh!

rlcee left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants