Skip to content

feat: introduce common/Link component to take care off internal and external links - #194

Closed
skaldarnar wants to merge 1 commit into
masterfrom
topic/common-link-component
Closed

skaldarnar wants to merge 1 commit into
masterfrom
topic/common-link-component

Conversation

@skaldarnar

@skaldarnar skaldarnar commented Jan 8, 2023 •

Copy link
Copy Markdown
Member

Based on Gatsby Link API.

image

  • double-check configuration of the indicator used for external links (e.g., should it be configurable, does it work to replace the icon with something else, does it work to omit the icon altogether).
  • update the import everywhere to use only our custom Link component
  • is it possible to write a linter rule that we don't import Link from gatsby?

@skaldarnar
skaldarnar requested a review from jdrueckert January 8, 2023 23:02
@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soloturn

Copy link
Copy Markdown
Contributor

Closing: the site moved from Gatsby to Astro in #263, and this draft builds on the Gatsby Link component, which no longer exists. Plain anchors are used now, so the internal/external link split can be revisited on the new code if still wanted.

@soloturn soloturn closed this Nov 11, 2026
@soloturn soloturn reopened this Nov 11, 2026
@soloturn

Copy link
Copy Markdown
Contributor

Closing, and sorry for the earlier boilerplate comment. This draft wraps Gatsby's Link component, which no longer exists since the move to Astro in #263, and it still had open to-dos. If marking external links is still wanted, it can be redone on the Astro code.

@soloturn soloturn closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants