Fix: UFlowNodeAddOn never overrides GetParentNode() - #390
Open
Locomody wants to merge 1 commit into
Open
Conversation
Fix UFlowNodeAddOn missing GetParentNode() override UFlowNodeBase::GetParentNode() is declared PURE_VIRTUAL. Under CHECK_PUREVIRTUALS=0 that macro expands to a body that only fatal-errors if actually called, so a subclass that never overrides it still compiles. Under CHECK_PUREVIRTUALS=1 it expands to =0, a genuine pure virtual, and any concrete class that leaves it unoverridden fails to compile as abstract. UFlowNode overrides GetParentNode(). UFlowNodeAddOn overrides every other pure virtual it inherits from UFlowNodeBase but missed this one, so every concrete UFlowNodeAddOn subclass is abstract under CHECK_PUREVIRTUALS=1, including the built-in predicate addons (AND, OR, NOT, RequireGameplayTags, CompareValues) and any project-defined addon. Add the same override UFlowNode already has, reusing GetFlowNodeSelfOrOwner() which UFlowNodeAddOn already resolves correctly to the owning top-level node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UFlowNodeAddOn missing GetParentNode() override
UFlowNodeBase::GetParentNode() is declared PURE_VIRTUAL. Under CHECK_PUREVIRTUALS=0 that macro expands to a body that only fatal-errors if actually called, so a subclass that never overrides it still compiles. Under CHECK_PUREVIRTUALS=1 it expands to =0, a genuine pure virtual, and any concrete class that leaves it unoverridden fails to compile as abstract.
UFlowNode overrides GetParentNode(). UFlowNodeAddOn overrides every other pure virtual it inherits from UFlowNodeBase but missed this one, so every concrete UFlowNodeAddOn subclass is abstract under CHECK_PUREVIRTUALS=1, including the built-in predicate addons (AND, OR, NOT, RequireGameplayTags, CompareValues) and any project-defined addon.
Add the same override UFlowNode already has, reusing GetFlowNodeSelfOrOwner() which UFlowNodeAddOn already resolves correctly to the owning top-level node.