fix(one line fix): use max output size for compaction budget#478
Open
qkunio wants to merge 1 commit into
Open
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #476
Problem
/compact会走一条单独的 provider 请求路径。#365 已经让普通对话使用模型配置里的max_output_size作为 completion token cap,但 compaction 路径里仍然只把reservedContextSize传给resolveCompletionBudget。这会让 OpenAI-compatible provider 在 compaction 时把模型的 context size 当成 output token cap 发送,最终触发
APIContextOverflowError。What changed
代码只增加一行,解决报错。
在 compaction 的 completion budget 解析里传入
this.agent.config.maxOutputSize,让/compact优先使用模型配置的输出上限。Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.