fix(tui): support exit shortcuts in startup session picker#473
Open
MicroGery wants to merge 2 commits into
Open
fix(tui): support exit shortcuts in startup session picker#473MicroGery wants to merge 2 commits into
MicroGery wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 503f3fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dafe866ca6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue.
Problem
Running
kimi -rwithout a session id opens the startup session picker. When the current directory has no sessions, the picker can only be dismissed with Escape, while the normal Kimi Code TUI supports exiting with repeated Ctrl-C or repeated Ctrl-D. This makes the startup picker inconsistent with the rest of the TUI.What changed
Added optional Ctrl-C and Ctrl-D handlers to the session picker component, then wired them only for the startup
kimi -rpicker path. In that startup flow, the picker now reuses the existing editor exit-confirmation behavior, so the first Ctrl-C or Ctrl-D shows the standard “press again to exit” hint and the second exits Kimi Code.The regular in-session session picker behavior is unchanged.
Added a focused component test covering Ctrl-C and Ctrl-D forwarding from the session picker.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Verification
pnpm --filter @moonshot-ai/kimi-code exec vitest run test/tui/components/dialogs/session-picker.test.tspnpm --filter @moonshot-ai/kimi-code run typecheck