Offer online play before local setup and acknowledge experimental models - #319
Draft
MoonlightByte wants to merge 1 commit into
Draft
MoonlightByte wants to merge 1 commit into
MoonlightByte wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows users previously began dependency setup without an online-play option, and local/custom models could be activated without acknowledging their experimental behavior.
This adds a tracked launch_game.bat and an online/local choice before the installer checks dependencies. Explicit launch arguments and NEQ_LOCAL_ONLY=1 preserve automated local startup. Installers running inside a checkout use that checkout and retain its launcher.
React and legacy settings request explicit, versioned local-model acknowledgment. Backend activation, endpoint saves/probes and client creation enforce it. Existing local selections remain selected without silently switching to a paid cloud provider. Headless users have a separate acknowledgment command; only version/time are recorded locally.
Validation: 32 Python provider/consent tests, 6 Windows launcher checks, 13 React settings tests, TypeScript checking, a Vite build and 3 Chromium provider-flow tests pass. Browser and API checks use synthetic/local providers; no paid AI calls. Frontend validation reused installed Node 24 dependencies; manifests and lockfile are unchanged.
This draft does not enable hosted BYOK or change game request parallelism. Online copy describes limited alpha access and links to the product page for availability.