feat-sync - Add new loading animation properties to MoonfinSettingsProfile - #271
Open
mattsigal wants to merge 1 commit into
Open
feat-sync - Add new loading animation properties to MoonfinSettingsProfile#271mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
- Add LoadingAnimationImage, LoadingAnimationSize, LoadingAnimationPosition, LoadingAnimationSpeed, and ShowLoadingAnimationText to MoonfinSettingsProfile in Jellyfin plugin model - Add matching properties to MoonfinSettingsProfile in Emby plugin model - Supports cross-device settings synchronization with Moonfin-Core PR #1416
Build SuccessfulThe plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds five loading animation preference properties (from Moonfin-Client/Moonfin-Core#1416) to
MoonfinSettingsProfilein both Jellyfin and Emby plugin models to support cross-device synchronization with Moonfin clients.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Area
Changes Made
List the key changes included in this PR.
LoadingAnimationImage,LoadingAnimationSize,LoadingAnimationPosition,LoadingAnimationSpeed, andShowLoadingAnimationTextnullable properties toMoonfinSettingsProfilein Jellyfin/backend/Models/MoonfinSettingsProfile.cs.[JsonPropertyName]tags toMoonfinSettingsProfilein Emby/Emby.Plugins.Moonfin/Models/MoonfinSettingsProfile.cs.Client Impact
Does this need matching changes in a client repo (Core, Smart-TV, Roku)?
loadingAnimationImageloadingAnimationSizeloadingAnimationPositionloadingAnimationSpeedshowLoadingAnimationTextCompatibility
bool?, an int toint?)Testing
Describe how this change was tested.
Test Steps
Moonfin.Server.csprojwithdotnet build.Emby.Plugins.Moonfin.csprojwithdotnet build.MoonfinSettingsProfile.test/data/synced_fields_test.dart.Screenshots (if applicable)
Include config page screenshots or request/response samples where relevant.
N/A
Checklist