bugfix-CWNU - Properly sync Continue Watching and Next Up Hidden Items - #267
Open
mattsigal wants to merge 1 commit into
Open
bugfix-CWNU - Properly sync Continue Watching and Next Up Hidden Items#267mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
Include settings.Global in UnionHiddenEntries so items hidden from one device persist in the global profile when other devices sync or push profile updates.
Build SuccessfulThe plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fixes an issue where items marked as "Hide from Continue Watching" or "Hide from Next Up" on one device were overwritten and wiped out when other devices synced or pushed profile updates to Moonbase. This caused items that were hidden from the CW&NU row to reappear when they shouldn't be able to.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Area
Changes Made
List the key changes included in this PR.
settings.GlobalinUnionHiddenEntriesacross both Jellyfin and Emby backend MoonfinSettingsService.cs implementations so existing hidden items stored in the global profile persist across subsequent device profile pushes.UnionHiddenEntriesto merge dictionaries by item ID and keep the latest ISO-8601 timestamp per item.SuccessiveDeviceProfileSavesPreserveGlobalHiddenItemsin AdminDefaultsMergeTests.cs verifying multi-device sync persistence and resolution.Client Impact
Does this need matching changes in a client repo (Core, Smart-TV, Roku)?
Compatibility
bool?, an int toint?)Testing
Describe how this change was tested.
dotnet buildon Jellyfin and Emby plugin projects to ensure clean compilation and verified unit tests in AdminDefaultsMergeTests.cs covering successive device profile saves and global resolution.Discovered this issue while investigating the CW&NU slow-down (which turns out to be unrelated), but can properly test this PR after I finish with the Moonfin-Core one.NOW PROPERLY TESTED :)Test Steps
Screenshots (if applicable)
Include config page screenshots or request/response samples where relevant.
These screenshots jump between Windows Desktop and Android-TV to show the near instant syncing between the clients in terms of hiding content from CW&NU:
Checklist