Jellyfin Session-API remote-control support - #1239
Conversation
|
Please split the RTL into its own separate PR |
4b93150 to
56f4ff2
Compare
|
Split out — RTL fixes are now in #1249, this PR is remote-control support only. |
controlfix87
changed the title
Implements VolumeUp/VolumeDown/ToggleFullscreen general commands and reports VolumeLevel in playback progress so a remote controller can sync its volume slider. Adds TV-only D-pad navigation commands (Move*/Select/Back/GoHome), declared only when PlatformDetection.isTV so non-TV builds never advertise support they can't back up. RTL fixes split out into a separate PR at reviewer request.
56f4ff2 to
6477816
Compare
controlfix87
changed the title
done. :) |
The movie/show details screen's action button row (Play/Subtitles/ Trailer/etc.) had its D-pad Left/Right hardcoded to a fixed index step, so a physical Right press moved focus left under RTL. The step direction now flips under RTL, matching the fix already applied elsewhere (LockedFocusRow, focusable_action_bar.dart). The action row and the Cast/Crew/Studios/Details/Similar tab bar also hugged the physical-left edge regardless of locale; both now use AlignmentDirectional so they sit on the correct (reading-start) side under RTL. Split out of #1239 at reviewer request.
|
Is there anything wrong here that I need to sort out? can you merge it? |
|
You realize that this is a FOSS hobby project and reviewing PRs takes time right? It will be reviewed by @RadicalMuffinMan when he has time, and in the context of the entire app's codebase. Submitting a PR does not mean it is guaranteed to be merged at all, never-mind on an immediate timeline. Please be patient. |
You're right. Thank you :) Came from work (as a dev.. LOL) |
3 participants
Pull Request
Summary
Implements the remaining Jellyfin Session-API remote-control support so Moonfin can be driven by any Jellyfin Session-API controller: volume up/down, fullscreen toggle, and TV-only D-pad navigation.
RTL fixes that were originally part of this PR have been split out into #1249.
Related Issues
Type of Change
Changes Made
VolumeUp/VolumeDown/ToggleFullscreengeneral commands and declared them inSupportedCommands.VolumeLevelin playback progress reports so a remote controller's volume slider can sync to Moonfin's actual volume.MoveUp/MoveDown/MoveLeft/MoveRight/Select/Back/GoHome), declared only whenPlatformDetection.isTVso non-TV builds never advertise support they can't back up.Platform
Testing
Test Steps
VolumeUp/VolumeDown/ToggleFullscreen, and that its D-pad control moves focus/selects/backs out/goes home against the TV session.Checklist