Skip to content

Doxygen correctness - #587

Merged
97gamjak merged 7 commits into
devfrom
doxygen-correctness
Sep 18, 2026
Merged

97gamjak merged 7 commits into
devfrom
doxygen-correctness

Conversation

@97gamjak

Copy link
Copy Markdown
Collaborator

close #586

@97gamjak
97gamjak requested review from ape33 and galjos September 13, 2026 14:05
@97gamjak 97gamjak linked an issue Sep 13, 2026 that may be closed by this pull request
@pq-perf-bot

pq-perf-bot Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 38.25M 38.25M -0.00% ✅
boxTransforms 10.67M 10.67M +0.00% ✅
constraints 11.06M 11.06M +0.00% ✅
coulombKernel 5.80M 5.80M +0.00% ✅
forceKernel 9.98M 9.98M -0.00% ✅
integrator 31.65M 31.65M -0.00% ✅
interWater 1689.12M 1689.12M -0.00% ✅
kinetics 8.55M 8.55M +0.00% ✅
linearAlgebra 2.08M 2.08M +0.00% ✅
nonCoulombPairs 5.48M 5.48M +0.00% ✅
shiftVector 5.81M 5.81M +0.00% ✅
virial 10.03M 10.03M -0.00% ✅

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@codecov

codecov Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.22%. Comparing base (c559660) to head (069a2ea).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #587      +/-   ##
==========================================
- Coverage   91.25%   91.22%   -0.04%     
==========================================
  Files         324      324              
  Lines       14766    14774       +8     
  Branches     4980     4996      +16     
==========================================
+ Hits        13475    13477       +2     
- Misses       1201     1207       +6     
  Partials       90       90              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

galjos
galjos previously approved these changes Sep 15, 2026
@github-actions
github-actions Bot dismissed galjos’s stale review September 18, 2026 06:22

Approval dismissed: new commits contain changes beyond a merge-up from dev.

@galjos galjos mentioned this pull request Sep 18, 2026
@97gamjak
97gamjak merged commit 8bb2404 into dev Sep 18, 2026
24 of 25 checks passed
@97gamjak
97gamjak deleted the doxygen-correctness branch September 18, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup doxygen comments and make warnings to errors

2 participants