Repository navigation
[WIP] Fix Northbound OTel propagation and streaming span lifetime - #4334
Merged
Merged
Conversation
JasonW404
marked this pull request as ready for review
November 12, 2026 06:21
JasonW404
requested review from
Dallas98,
WMC001,
YehongPan,
hhhhsc701 and
jeffwu-1999
as code owners
November 12, 2026 06:21
jeffwu-1999
pushed a commit
that referenced
this pull request
Nov 13, 2026
* chore: bootstrap output protocol and history patch * fix(agent): converge output parsing and replay runtime-only history * test(agent): align history and case-insensitive protocol regressions * fix(agent): retain runtime history echo protection * fix(agent): defer mixed final answer streaming until execution confirmation * test: refresh reviewed prompt baselines for protocol patch * fix(observability): trace northbound requests through complete streaming responses * test: align northbound monitoring environment precedence * fix(agent): restore legacy history rendering and deduplicate results * Revert "test: align northbound monitoring environment precedence" This reverts commit 7995430. * Revert "fix(observability): trace northbound requests through complete streaming responses" This reverts commit 36109ae. * [WIP] Fix Northbound OTel propagation and streaming span lifetime (#4334) * fix(observability): trace northbound requests through complete streaming responses * test: align northbound monitoring environment precedence * test: keep split northbound validation rooted in its checkout * chore: set v2.8.5 release version * fix(agent): deduplicate sandbox string representations in history * chore: remove unrelated PR4328 formatting and verify legacy trace route * fix: restore ordinary mixed-answer streaming in CodeAgent * fix: omit implicit output cap when default reserve is unset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Northbound requests previously had HTTP tracing disabled, lacked monitoring configuration in deployment, and did not forward W3C trace context to Runtime. Enable the existing instrumentation and propagate traceparent/tracestate alongside the internal JWT so Northbound, Runtime, Agent and tool spans share one trace. Keep the Northbound server span open through completion of the final ASGI send, including failure and disconnect handling.
This PR is split from #4328 and targets hotfix/v2.8.5. It contains only Northbound tracing, Docker/Helm monitoring configuration, and corresponding tests/formal assets. Agent output parsing and tool-result history remain in #4328. No new telemetry dependency or global HTTPX instrumentation is added.
Validation after splitting:
Deployment: rebuild the shared backend image and recreate affected backend containers with the updated Compose/Helm monitoring configuration. Enable telemetry; explicit URL allowlists must include /nb/ and /agent/internal/northbound/. Span completion means the final server ASGI send returned, not acknowledgement by the client.