Stop committing the shade dependency-reduced-pom - #47
Merged
estebanzimanyi merged 1 commit intoJul 23, 2026
Merged
Conversation
The maven-shade-plugin regenerates dependency-reduced-pom.xml on every package, and the committed copy had drifted: it still declared the old com.mobilitydb:jmeos:1.0.0 system-scope dependency while the build resolves org.jmeos:meos:1.0. Set createDependencyReducedPom to false — as the sibling MobilityKafka does — and remove the committed file so the generated artifact cannot drift again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
maven-shade-pluginregeneratesflink-processor/dependency-reduced-pom.xmlon everypackage. The committed copy is stale: it declares the oldcom.mobilitydb:jmeos:1.0.0system-scope dependency, while the activepom.xmlresolvesorg.jmeos:meos:1.0(tracking master).This sets
<createDependencyReducedPom>false</createDependencyReducedPom>on the shade execution — the convention the sibling MobilityKafka uses — and removes the committed file. MobilitySpark and MobilityKafka do not commit this file; MobilityFlink now matches.