Generate the value-type hash and hashExtended surface - #243
Merged
estebanzimanyi merged 2 commits intoJul 31, 2026
Merged
Conversation
The set, span and spanset hash and hashExtended functions are now emitted by the generator as the bare overloaded hash() and hashExtended() (with a UBIGINT seed), matching the MobilityDB SQL surface. A new (container, by-value seed) -> scalar shape covers the extended variants alongside the existing unary hash. The hand-written set_hash/span_hash/spanset_hash registrations and their _hash_extended variants, together with their implementations and declarations, are removed; the generated surface now covers them. The parity tests are updated to the bare names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
set,spanandspansethashandhashExtendedfunctions are nowemitted by the generator as the bare overloaded
hash()/hashExtended()(with a
UBIGINTseed), matching the MobilityDB SQL surface, instead of beinghand-registered under the type-prefixed
set_hash/span_hash/spanset_hashnames.A
(container, by-value seed) -> scalarshape covers the extended variantsalongside the existing unary hash. The hand-written registrations, their
implementations and declarations are removed; the generated surface covers
them. The parity tests use the bare names.
The regenerated surface also reflects the bare hash names for the other
families, so the whole hash surface is the single overloaded
hash/hashExtendedresolved by argument type.