Generate the npoint network-point family (tnpoint, npoint, nsegment) - #238
Merged
estebanzimanyi merged 2 commits intoJul 31, 2026
Merged
Conversation
Registers the npoint temporal family — the 2D-planar twin of cbuffer. Both
inherit Spatial<T> and are non-geodetic; the only difference is that npoint
carries no SRID/geometry of its own — a route id resolves against the fixed
`ways` road network. This gives tnpoint the whole inherited Spatial<T> and
Temporal<T> surface (205 registrations) generated from the catalog.
- src/npoint/tnpoint.{cpp,hpp}: npoint/nsegment/tnpoint BLOB types, the
<-> VARCHAR casts, and fixed-struct blob marshalling (palloc(sizeof), like
Span/STBox — Npoint {rid,pos} and Nsegment {rid,pos1,pos2} are fixed size).
- Generator: Npoint/Nsegment in the PTR_IN/PTR_RET base-value maps;
NpointTypes::tnpoint() in the temporal type maps; tnpoint/npoint/nsegment in
REGISTERED_FAMILIES; the blob<->struct marshaller helpers in the preamble.
- ways network wiring: the ways.csv (100 routes, SRID 5676) is embedded as
src/ways_csv.inc and installed at load via ConfigureMeosWaysCsvOnce (env
override WAYS_CSV), mirroring the SRID-CSV wiring. Without it npoint has no
route resolution (SRID 0).
Adds test/sql/tnpoint.test (SRID and position interpolation over the ways
network).
src/index/rtree_module.cpp.merged and src/include/index/rtree_module.hpp.merged are leftover merge artifacts accidentally committed (the .cpp.merged still contains raw conflict markers). They are not referenced by the build (CMake compiles rtree_module.cpp / includes rtree_module.hpp) — pure junk, removed.
estebanzimanyi
force-pushed
the
feat/duck-npoint-family
branch
from
July 31, 2026 10:56
7dfa774 to
604b8a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the npoint temporal family — the 2D-planar twin of cbuffer. Both inherit
Spatial<T>and are non-geodetic; the only difference is that npoint carries no SRID/geometry of its own — a route id resolves against the fixedwaysroad network. This givestnpointthe whole inheritedSpatial<T>+Temporal<T>surface (205 registrations) generated from the catalog.src/npoint/tnpoint.{cpp,hpp}—npoint/nsegment/tnpointBLOB types, the<-> VARCHARcasts, and fixed-struct blob marshalling (palloc(sizeof), likeSpan/STBox—Npoint {rid,pos}andNsegment {rid,pos1,pos2}are fixed size).Npoint/Nsegmentin thePTR_IN/PTR_RETbase-value maps;NpointTypes::tnpoint()in the temporal type maps;tnpoint/npoint/nsegmentinREGISTERED_FAMILIES; the blob↔struct marshaller helpers in the preamble.ways.csv(100 routes, SRID 5676) is embedded assrc/ways_csv.incand installed at load viaConfigureMeosWaysCsvOnce(env overrideWAYS_CSV), mirroring the SRID-CSV wiring. Without it npoint has no route resolution (SRID 0).Adds
test/sql/tnpoint.test(SRID and position interpolation over the ways network).The MEOS side is fully ready (
T_NPOINT/T_NSEGMENT/T_TNPOINT,meos_npoint.h); this is a pure binding-side family registration, modelled on the existing cbuffer family.