spaceSplit and spaceTimeSplit accept LATERAL column inputs - #132
Closed
estebanzimanyi wants to merge 1 commit into
Closed
spaceSplit and spaceTimeSplit accept LATERAL column inputs#132estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
estebanzimanyi
added a commit
that referenced
this pull request
May 14, 2026
The portfile pinned REF f11b7443e (Mar 30) but the SHA512 corresponds to 742c1fb5 (May 11). Vcpkg's SHA512 cache silently masked the discrepancy on some runs (PR #132 succeeded by reusing a cached tarball that matched the SHA512), but a fresh download fetches f11b7443e's content which still spells the catalog enum `meosType` (lowercase). That makes `using meosType = MeosType;` in src/include/tydef.hpp fail to compile because `MeosType` (the Pascal-cased rename introduced by MobilityDB PR #790, merged Apr 28) is not yet defined at REF f11b7443e. Update REF to 742c1fb5 so it matches the existing SHA512. The tarball content vcpkg actually used in PR #132's green run is now the explicit pin, and the forward-compat alias compiles cleanly. Pure portfile fix; no other changes.
estebanzimanyi
added a commit
that referenced
this pull request
May 14, 2026
The portfile pinned REF f11b7443e (Mar 30) but the SHA512 corresponds to 742c1fb5 (May 11). Vcpkg's SHA512 cache silently masked the discrepancy on some runs (PR #132 succeeded by reusing a cached tarball that matched the SHA512), but a fresh download fetches f11b7443e's content which still spells the catalog enum `meosType` (lowercase). That makes `using meosType = MeosType;` in src/include/tydef.hpp fail to compile because `MeosType` (the Pascal-cased rename introduced by MobilityDB PR #790, merged Apr 28) is not yet defined at REF f11b7443e. Update REF to 742c1fb5 so it matches the existing SHA512. The tarball content vcpkg actually used in PR #132's green run is now the explicit pin, and the forward-compat alias compiles cleanly. Pure portfile fix; no other changes.
Member
Author
Reviewer's quickstart — ~2-3 minutesWhat this PR does: spaceSplit and spaceTimeSplit accept LATERAL column inputs. Risk: focused, single-purpose. Spot-check the source diff + matching tests; CI confirms. Cross-link: Linux arm64 CI here needs #161 for the orthogonal |
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
3 times, most recently
from
June 5, 2026 20:13
0ae9c41 to
25546aa
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 5, 2026 20:33
9a00e94 to
9e38105
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 5, 2026 21:19
25546aa to
b72c0f9
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 5, 2026 21:21
9e38105 to
2b1a573
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 5, 2026 21:28
b72c0f9 to
2057fb5
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
2 times, most recently
from
June 5, 2026 21:29
68edd2c to
76f47de
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 6, 2026 04:38
2057fb5 to
a44739e
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 6, 2026 04:38
76f47de to
7cccd91
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 6, 2026 06:10
a44739e to
c74aea5
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
2 times, most recently
from
June 6, 2026 06:35
041fd5b to
d8fcde3
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 6, 2026 06:35
c74aea5 to
92db319
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 6, 2026 07:15
d8fcde3 to
f10cbd6
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 6, 2026 12:20
87353e3 to
5555d7c
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 6, 2026 12:24
f10cbd6 to
980f57f
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 6, 2026 23:54
5555d7c to
99b514c
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 6, 2026 23:54
980f57f to
fa29b67
Compare
estebanzimanyi
force-pushed
the
feat/parity-additions-batch
branch
from
June 7, 2026 05:27
99b514c to
13eaacb
Compare
estebanzimanyi
force-pushed
the
feat/spacesplit-lateral
branch
from
June 7, 2026 05:27
fa29b67 to
1717681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-register both splitters as in_out_function table functions so per-row parameters (tgeompoint, sizing constants, origin, duration, torigin, bitmatrix) are read at exec time from the input DataChunk rather than bound once from literals; pattern mirrors duckdb/extension/icu/icu-table-range.cpp. When the input chunk drains, the function leaves output.size() at zero and returns NEED_MORE_INPUT, matching PhysicalTableScan's FINISHED-by-chunk-size contract and PhysicalTableInOutFunction's NEED_MORE_INPUT advance. test/sql/parity/058c_tpoint_split_lateral.test exercises the LATERAL column-input path alongside 058b's literal-input regression. Stacked on #126, which carries the MEOS pin bump and API adaptations the build depends on.