Implement STBox.expand_stbox - #85
Merged
Merged
Conversation
The method returned a plain copy of "this" and ignored "other" entirely, so callers silently got a wrong box. The call doing the work was commented out and named stbox_expand_space, whose signature takes a double rather than a box. Call stbox_expand, which expands the second box with the first one, and drop the unused leading parameter. Add a test covering the disjoint case, which the previous body could not produce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expand_stboximplements the expansion ofthiswithother, returning the smallest box containing both.The body calls
stbox_expand, which expands the second box with the first one in place. That function is public since MobilityDB#1525, so the binding reaches it directly. The signature is an instance method taking a single box, sinceexpand_stboxis applied tothis.The test covers the disjoint case,
STBox X((1, 1),(2, 2))expanded withSTBox X((3, 3),(4, 4))givingSTBox X((1, 1),(4, 4)), together with a contained case and the Z and XT variants.