Repository navigation
🐛 Bump Bun to 1.4.4 for CVE-2026-111497 (Node2Shell) - #25
Merged
Merged
Conversation
Lockfile-only bump of webpki-root-certs 1.0.6 -> 1.0.10, which drops emSign ECC Root CA - G3 from the bundled Mozilla root store after the eMudhra intermediate-key compromise. No Cargo.toml changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
rustls-webpki < 0.103.16 accepts certificate paths through the eight distrusted emSign intermediate keys (CVE-2026-111943). 0.103.16 adds them to the path-building blocklist. Lockfile-only change: version and checksum of rustls-webpki, nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Supply-chain hardening: mutable tags can be repointed after review, so every external reference is now pinned to immutable content. - Dockerfile base images pinned by sha256 digest and every GitHub Action pinned to a 40-character commit sha. Each pin was resolved and then independently verified; the human-readable tag stays in a comment. - dtolnay/rust-toolchain is pinned to a master commit, so each step now passes toolchain: stable explicitly. - Security-driven bumps: lychee-app/lychee-action -> lycheeverse/lychee-action (the lychee-app org does not exist, a repojacking risk) and softprops/action-gh-release v2 (unsupported) -> v3.0.3 (inputs checked against v3's action.yml). - scripts/check_immutable_refs.py fails on any mutable FROM, COPY --from, uses: or image: reference. Wired into make ci (lint_immutable_refs) and a new "Pinned refs" workflow. - Runtime stage: ca-certificates is installed explicitly so each build pulls the post-eMudhra trust store despite the frozen base image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
…bun-version
Review-bot findings on the pinned-refs guard, applied across the repos:
- COPY --from is only parsed inside COPY instructions, continuation lines
are joined, and RUN --mount=...,from=<image> is checked.
- A FROM's own AS alias no longer exempts its base (only earlier stages).
- $VAR / ${VAR} refs resolve from ARG defaults, which must be digest-pinned;
unresolved refs fail unless pin-exempt.
- Workflow image: and scalar container: values with ${{ }} fail closed
unless pin-exempt; action.yml runs.image may name a local Dockerfile.
- action.yml/action.yaml metadata is scanned wherever it lives, Dockerfile
names match case-insensitively, unreadable files are errors.
- pin-exempt covers image lines only, never uses:; action refs must fully
match owner/repo[/path]@<40-hex>; quoted YAML keys are recognised.
- Any *-version: latest action input now fails.
- Pinned refs workflow: on pull_request, run the base branch's copy of the
guard so a PR cannot weaken its own check.
- Makefile: lint_immutable_refs is .PHONY; success message reworded.
- docs-lint: bun-version latest -> 1.4.3 (exact; the guard now rejects it).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
…stable 1.99.1 Guard v5: - pin-exempt is cleared by a blank line; blank lines inside a continuation are skipped and continuation lines are joined like Docker (no inserted space, the next line keeps its indent). - The # escape= parser directive is honoured (backtick continuations). - action.yml runs.image is exempt only when it ends in Dockerfile or dockerfile, as the runner requires; bare and docker:// images must be pinned. - YAML keys are recognised in flow style and with a space before the colon, every uses:/image: ref on a line is checked, and uses: must be owner/repo[/path]@<40-hex>. - Pinned refs workflow comment: the base copy protects the checker script, the workflow file itself needs CODEOWNERS or a ruleset. - setup-bun steps without bun-version now pin 1.4.3. Rust CI (red on main since floating stable moved to 1.99.1): - async-trait 0.1.92 (clippy double_must_use from its expansion). - current_os() returns std::env::consts::OS (clippy needless_match). - h2, rustls and tokio 1.53.3 lock bumps for new RUSTSEC advisories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
serde_yaml 0.9.34+deprecated pulls in unsafe-libyaml, which
RUSTSEC-2024-0449 marks unmaintained (archived, a c2rust translation of
libyaml into unsafe Rust). That fails `cargo deny check advisories`.
Swap both YAML call sites (scenario loader, `appctl init --config`) to
serde-saphyr 2.0.0 (pure safe Rust, deserialize only) with
`strict_booleans: true`, so YAML 1.1 words like `yes`/`n`/`on` stay
strings in untyped places. Without it, `args: {n: 3}` makes the untagged
ScenarioStep fail because the key `n` becomes `false`; a regression test
covers this.
Behaviour differences for scenario files and --config files:
- Merge keys `<<` are now applied instead of kept as a literal key.
- Untyped `.nan` / `.inf` in scenario `args` are rejected.
- A leading-zero number like `012` in scenario `args` is parsed as 12.
- Parse errors now print a multi-line source snippet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
…blowup
- An anchor or tag before a block key (`- &step uses: x`, `- !!str uses: x`,
`{ &k uses: x }`) no longer hides the key from the check.
- Verbatim tags with commas (`!<tag:yaml.org,2002:seq> [...]`) now open a
flow collection.
- Each node property must end at whitespace or a bracket, so a run like
`&&&&x` has one split instead of exponentially many (the old pattern hung
on 30 characters).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`!<[^>]*>` ran to the end of the line from every comma when the tag was never closed, so a flow line of repeated `,!<` was quadratic (32k repeats took 8s). YAML verbatim tags hold URI characters only, so the tag now stops at whitespace or another `<`; the same line takes 0.04s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`bun-version: &v latest` (and `&v` with `latest` on the next line) slipped past the `latest` check because the value was taken to be `&v`, and `uses: &pin owner/repo@<sha>` was wrongly rejected for the same reason. Node properties after the colon are now skipped before the value is read, on the key's own line and on the line below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
The serde-saphyr lock resolved annotate-snippets 0.12.17, published on the last day of the 7-day supply-chain cooldown, and it alone pulled memchr from 2.7.6 to 2.8.3. 0.12.12 satisfies serde-saphyr's requirement, is what Tauri-Template already resolves, and needs no memchr bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`container: &c` followed by `{ image: <pinned> }` on the next line was
read as a scalar image and rejected. A continuation that opens a `{` or
`[` collection is now left to the per-line flow scanner, which already
checks the keys inside it, so a mutable image there is still flagged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`flow_depth` stripped only comments preceded by whitespace, so a `# }` comment at column 0 inside a multi-line flow mapping lowered the depth and a later `b: 2, uses: owner/repo@v4 }` continuation was read as block YAML and skipped. Comments at the start of a line are now stripped too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Bun 1.4.3 and earlier ship a Brotli decoder out-of-bounds write (GHSA-663w-cv8g-jj2p). Move every setup-bun pin to the fixed 1.4.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CVE-2026-111497 ("Node2Shell"), a Brotli decoder out-of-bounds write in Bun 1.4.3 and earlier (GHSA-663w-cv8g-jj2p). Bun 1.4.4 is the fixed release.
Changes
setup-bunbun-versionpins in.github/workflows/from 1.4.3 to 1.4.4.oven/bun).Testing
make ci): every target passes exceptaudit, wherebun auditreports existing advisories inbun.lockdependencies (vite, postcss, sharp, zod, etc.). That failure is independent of this change, which only edits workflow YAML.Generated by Claude Code
Summary by cubic
Fixes CVE-2026-111497 (Node2Shell), a Brotli decoder out-of-bounds write in Bun 1.4.3 and earlier, by moving all three
setup-bunversion pins in the workflow files to the fixed 1.4.4 release.The change only touches workflow YAML, so the pre-existing
bun auditadvisory failures are unaffected.Written for commit 0ee6a09. Summary will update on new commits.