Handle SMB URIs in Linux desktop_drop path parsing#474
Merged
Conversation
Agent-Logs-Url: https://github.com/MixinNetwork/flutter-plugins/sessions/3a953253-25e5-4d9c-b425-fb29e5f50650 Co-authored-by: boyan01 <17426470+boyan01@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Linux files from smb-pathes unable to be dropped
Handle SMB URIs in Linux desktop_drop path parsing
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux drops can include
smb://...entries, but the current parser unconditionally callsUri.toFilePath(), which throws for SMB URIs and causes dropped items to be discarded. This change updates Linux drop parsing to preserve SMB URIs while keeping existing file-URI behavior unchanged.Linux drop URI handling
performOperation_linux(packages/desktop_drop/lib/src/channel.dart), parse each dropped line once and branch by scheme:smb→ keep original URI stringfile) → continue converting viatoFilePath()Focused regression coverage
packages/desktop_drop/test/channel_linux_test.dartto cover:smb://server/share/file.txt)file:///tmp/file.txt→/tmp/file.txt)