PRODENG-3443: add upgrade smoke test (MCR stable-25.0/MKE 3.8.8 → stable-29.2/MKE 3.9.2)#629
Open
james-nesbitt wants to merge 1 commit into
Open
PRODENG-3443: add upgrade smoke test (MCR stable-25.0/MKE 3.8.8 → stable-29.2/MKE 3.9.2)#629james-nesbitt wants to merge 1 commit into
james-nesbitt wants to merge 1 commit into
Conversation
TestUpgradeLegacyToModern provisions a 6-node legacy Linux cluster (RHEL8/Rocky8/Ubuntu22, MCR stable-25.0, MKE 3.8.8), then upgrades it in place to MCR stable-29.2 / MKE 3.9.2 using a second Apply() call on the same Terraform infrastructure. Design: - runUpgradeTest() follows the same infra pattern as runSmokeTest() (defer terraform.Destroy first, tagged resources, temp SSH dir). - bumpVersions() unmarshals the Terraform-generated launchpad YAML, updates spec.mcr.channel and spec.mke.version, and re-marshals — preserving host addresses, SANs, LB names, and install flags verbatim. - Two sequential Apply() calls: base install then upgrade. Launchpad's UpgradeMCR and UpgradeMKE phases handle the delta automatically. - Reset() is best-effort (same rationale as the other smoke tests). Infra: - 90m go test timeout (install ~20min + upgrade ~20min + reset + buffer). - smoke-upgrade CI job gated by smoke-upgrade or smoke-test PR label. - Makefile target: make smoke-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://mirantis.jira.com/browse/PRODENG-3443
Summary
Adds an automated upgrade smoke test that provisions a 6-node Linux cluster (RHEL8/Rocky8/Ubuntu22), installs MCR
stable-25.0/ MKE3.8.8, then upgrades in place to MCRstable-29.2/ MKE3.9.2using a secondApply()call on the same infrastructure.This is the first run — expected to surface MCR 25→29 upgrade issues so they can be fixed iteratively.
Changes
test/smoke/upgrade_test.go—upgradeConfigstruct,runUpgradeTest(),bumpVersions()YAML mutator,TestUpgradeLegacyToModernMakefile—make smoke-upgrade(90m timeout).github/workflows/smoke-tests.yaml—smoke-upgradeCI job, gated bysmoke-upgradeorsmoke-testlabelDesign
bumpVersions()unmarshals the Terraform-generatedlaunchpad_yamloutput, updatesspec.mcr.channelandspec.mke.version, and re-marshals — preserving host addresses, SANs, LB names, and install flags verbatim. Two sequentialApply()calls on the same infrastructure handle install then upgrade.Known concerns (MCR 25→29)
See PRODENG-3443 for the full list. Key risks: package repo transition, storage driver compatibility, kernel version floor (MCR 29 requires ≥5.4), and MKE 3.8 compatibility on MCR 29 as an intermediate state.