Repository navigation
refactor(codegen)!: resolve misleading and clashing generated names - #132
Merged
Merged
Conversation
Rename Flow to FlowNodes, drop the kind prefix and the code suffix from shared constants, and rename the runtime BpmnError/BpmnEscalation to BpmnErrorDefinition/BpmnEscalationDefinition. Refs #120
emaarco
enabled auto-merge (squash)
September 29, 2026 09:12
Contributor
|
Test Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
What
Flow→FlowNodes(Kotlin, Java, C#), so it no longer clashes withkotlinx.coroutines.flow.FlowMessages.MESSAGE_FORM_SUBMITTED→Messages.FORM_SUBMITTED(kept when nothing valid remains)shared-definition-collision, so constant names never depend on other modelsBpmnError/BpmnEscalation→BpmnErrorDefinition/BpmnEscalationDefinition, avoiding clashes with the engines'BpmnErrorServiceTasksstays as is (see issue comment)C# member names of shared definitions are now derived from the constant name instead of the raw name, so the prefix stripping applies there too.
Breaking
Yes — lands before 6.0.0 (#88). The v6 migration guide, generated-api docs and the migration skill are updated.