feat: implement stablecoin peg deviation benchmark route#107
feat: implement stablecoin peg deviation benchmark route#107barnabasolutayo-lgtm wants to merge 7 commits into
Conversation
|
@barnabasolutayo-lgtm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Verified: registerBenchmarkRoutes(app) wired in index.ts; /benchmark/:asset queries price_points with valid pair_key/timestamp columns, parameterized, 404 on unwatched pair; includes a test. Clean merge with main. Closes #98.
Miracle656
left a comment
There was a problem hiding this comment.
The route itself looks good — registerBenchmarkRoutes wired in index.ts, /benchmark/:asset over price_points (valid pair_key/timestamp), 404 on unwatched pair, parameterized, with a test. The only blocker is that it now conflicts with sibling routes that merged since you branched (both touch src/index.ts route registration and src/api/schemas.ts).
A quick rebase resolves it:
git fetch origin
git rebase origin/main
# in src/index.ts keep ALL registerXxxRoutes(app) lines (union), same for schemas.ts
git push --force-with-leaseThen I'll merge. Thanks!
…AV example, Python SDK (Miracle656#109) * feat(ingest): add Aquarius AMM venue adapter (Miracle656#103) * feat(ingest): add Reflector oracle adapter (Miracle656#104) * feat(routes): add /compare/:asset oracle comparison endpoint (Miracle656#104) * feat(examples): add portfolio NAV example app skeleton (Miracle656#105) * feat(sdk): add Python SDK data models (Miracle656#106) * feat(sdk): add Python SDK LensClient (Miracle656#106) * feat(sdk): add Python package init (Miracle656#106) * feat(sdk): add Python package setup.py (Miracle656#106) * feat(examples): add portfolio NAV page with Horizon + Lens price lookup (Miracle656#105) * feat(server): wire Aquarius ingester and oracle comparison route (Miracle656#103 Miracle656#104)
Co-authored-by: Brooks Student Portal <student@brooks.edu> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Introduces src/ingest/cex/ with a CexAdapter interface (fetchTicker, fetchOrderBook, adapter registry) and a fully deterministic MockCexAdapter for testing. 14 unit tests cover ticker fields, order-book depth, unknown pairs, case normalisation, and registry round-trips. closes Miracle656#99 Co-authored-by: adaofweb3 <adaofweb3@users.noreply.github.com>
62150c6 to
1c8e46b
Compare
##closes #98