Repository navigation
feat: Rank symbol queries with BM25 only - #308
Closed
flyinprogrammer wants to merge 1 commit into
Closed
flyinprogrammer wants to merge 1 commit into
flyinprogrammer wants to merge 1 commit into
Conversation
Bare identifier queries ("MyService", "Sinatra::Base") are exact lookups: the
dense list adds near-miss neighbours that the definition boost then has to
outrank. Set _ALPHA_SYMBOL from 0.3 to 0.0 so symbol queries fuse BM25 only;
NL queries are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307
Summary
Bare identifier queries (
MyService,Sinatra::Base) currently give the dense list 30% of the fused score. Setting their weight to 0 ranks them by BM25 alone; natural-language queries are unchanged.Evidence
test_resolve_alpha[MyService-None-0.0]fails onmain'sboosting.pyand passes here. It checks the constant; the behaviour is covered by the benchmark below.make test391 passed;make lintandmake typecheckclean.run_benchmark0.852 → 0.854.Merge Danger
Door: two-way
A one-constant ranking change with no index or cache change; reverting restores the old ranking exactly.
Blast Radius: ranking
Only queries that
is_symbol_queryclassifies as identifiers. The dense search still runs for them; its scores are just weighted 0.