Repository navigation
feat: Strengthen the same-file saturation decay - #306
Closed
flyinprogrammer wants to merge 1 commit into
Closed
flyinprogrammer wants to merge 1 commit into
flyinprogrammer wants to merge 1 commit into
Conversation
Each extra chunk from an already-listed file was scaled by 0.5, so a strong second chunk of the top file still pushed other files out of the top 10. That hurts queries whose answer spans several files. Lower _FILE_SATURATION_DECAY to 0.25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305
Summary
Each extra chunk from an already-listed file is scaled by
_FILE_SATURATION_DECAY. At 0.5, a strong second chunk of the top file still pushes other files out of the top 10; 0.25 lets another file through:Evidence
The new
test_rerank_topk_prefers_another_file_over_a_second_chunkasserts the 0.25 order above.main'spenalties.py): 1 failed.make test392 passed;make lintandmake typecheckclean.NDCG@10, compared with
main(95% CIs resample repos):run_benchmark: 0.852 → 0.853. Decay 0.1 and 0.0 change nothing further; 0.75 and 1.0 are worse.Merge Danger
Door: two-way
A one-constant ranking change with no index or cache change; reverting restores the old ranking exactly.
Blast Radius: ranking
Only result order changes, and only when a file has several chunks among the candidates; the result count is unchanged.