Skip to content

Improve/clarify error message #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miladkhoshdel merged 2 commits into from
Sep 12, 2026
Merged

Improve/clarify error message #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7932f5e
fix: clarify invalid input error message
Miladkhoshdel Sep 12, 2026
88b3996
test: clarify invalid input error message
Miladkhoshdel Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion luhn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def _digits(value: NumberLike) -> str:

if not cleaned or not cleaned.isdigit():
raise ValueError(
"value must contain digits only, with optional spaces or hyphens"
"value must contain digits only, with optional spaces, hyphens, "
"dots, slashes, backslashes, or commas"
)

return cleaned
Expand Down
7 changes: 6 additions & 1 deletion test_luhn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ def test_append_check_digit(self):
self.assertEqual(append_check_digit("7992739871"), "79927398713")

def test_rejects_non_digit_payloads(self):
with self.assertRaises(ValueError):
expected_message = (
"value must contain digits only, with optional spaces, hyphens, "
"dots, slashes, backslashes, or commas"
)

with self.assertRaisesRegex(ValueError, expected_message):
calculate_check_digit("123x")

def test_rejects_unsupported_types(self):
Expand Down
Loading