Repository navigation
Ticket #5167: typo fixes in src/filemanager/file.c - #5167
Conversation
|
|
||
| if (ctx->ignore_all | ||
| || file_error (ctx, TRUE, _ ("Destination\n%s\nmust be a directory\n%s"), dest) | ||
| || file_error (ctx, TRUE, _ ("Destination\n%s\nmust be a directory"), dest) |
There was a problem hiding this comment.
Inside file_error, an empty string is passed as a second format argument, but my understanding is that it is harmless to remove the format descriptor, even though it's a somewhat questionable design.
Online C Draft Standard (n1256), s. 7.19.6.1, p. 2:
The fprintf function writes output to the stream pointed to by stream, under control of the string pointed to by format that specifies how subsequent arguments are converted for output. If there are insufficient arguments for the format, the behavior is undefined. If the format is exhausted while arguments remain, the excess arguments are evaluated (as always) but are otherwise ignored. The fprintf function returns when the end of the format string is encountered.
There was a problem hiding this comment.
Sure it's not a bug but seems to be unintentional leftover and looks misleading.
|
/rebase |
Signed-off-by: Phil Krylov <phil@krylov.eu>
5432db1 to
c265222
Compare
Proposed changes
A typo fix in comment, a typo fix in printf format string
Checklist
git commit --amend -smake indent && make check)