Hide ^M in editor

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1652
Reporter	slavazanko (@slavaz)
Mentions	zaytsev (@zyv), gotar@….pl, pmiscml@….com, cravchik@….ru (@kravich)

Need to hide ^M symbols at end of lines in text files with '\r\n' line ends.

Better way: create keybinding for toggle ^M symbols.

Note

Original attachments:

• detect-linebreaks.patch (raw) by pfalcon (pmiscml@….com) on Jan 15, 2011 at 23:38 UTC
• 0001-Ticket-1652.patch (raw) by angel_il (@ilia-maslakov) on Mar 29, 2011 at 14:01 UTC
• 0002-added-options-editor_autodetect_linebreak.patch (raw) by angel_il (@ilia-maslakov) on Mar 29, 2011 at 14:01 UTC
• mc-4.8.1-ticket-1652-linebreaks.patch (raw) by huksley (huksley@….ru) on May 31, 2013 at 7:54 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 2, 2009 at 12:52 UTC (comment 1)

• Description edited

[mc-butler]

Changed by birdie (aros@….com) on Oct 13, 2009 at 17:01 UTC (comment 2)

Or even better:

suggest or "guess" line endings upon saving a file (WIN/LIN/MACOS).

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Oct 13, 2009 at 17:56 UTC (comment 2.3)

• Description edited

Replying to birdie:

Or even better:

suggest or "guess" line endings upon saving a file (WIN/LIN/MACOS).

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Oct 13, 2009 at 17:56 UTC (comment 4)

• Description edited

ups...

You mean #1571?

[mc-butler]

Changed by SzG (szg@….com) on Nov 14, 2009 at 20:11 UTC (comment 5)

If you implement an option, \r SHOULD BE SHOWN by default.

Mcedit is used as part of Cygwin by poor people who are forced to use Windows in the office (like myself). On Windows not all editors are preserving \n linefeeds like Far-manager, other editors may insert \r. The best way to check it is mcedit.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 21, 2010 at 14:56 UTC (comment 6)

• Version changed from 4.7.0-pre3 to master
• Status changed from new to accepted
• Milestone changed from 4.7 to 4.7.1
• Owner set to angel_il

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 21, 2010 at 19:25 UTC (comment 7)

• Milestone changed from 4.7.1 to Future Releases

[mc-butler]

Changed by sorin (@ssbarnea) on Sep 26, 2010 at 11:12 UTC (comment 8)

Currently this is one of the biggest issues with mc. The inability to work with different line ending give problems in lots of cases. It is something really common for see CR/LF even on linux from files coming from windows share, ftp, source control.

Like other editor mc should be able to detect the line ending and keep it. It could should the line ending in the status bar.

[mc-butler]

Changed by zaytsev (@zyv) on Sep 26, 2010 at 12:00 UTC (comment 9)

Oh really? How did you conclude that mc is *unable* to work with different line endings?! It currently keeps the endings of edited files, however, \r endings are not shown by default, whereas ^M are. So it's perfectly safe to edit any kinds of files. Moreover, you can save files using any scheme that you want.

All it takes is to add the ability to optionally display alien endings and add options to select default endings scheme / and heuristics on keeping auto-detected endings or auto-converting them to the default scheme.

[mc-butler]

Changed by zaytsev (@zyv) on Sep 26, 2010 at 12:00 UTC (comment 10)

• Cc set to zaytsev

[mc-butler]

Changed by gotar (gotar@….pl) on Sep 29, 2010 at 14:41 UTC (comment 11)

• Cc changed from zaytsev to zaytsev, gotar@….pl

[mc-butler]

Changed by pfalcon (pmiscml@….com) on Jan 6, 2011 at 22:02 UTC (comment 12)

• Cc changed from zaytsev, gotar@….pl to zaytsev, gotar@….pl, pmiscml@….com

This is truly needed feature, and I lost my patience and went to implement it myself. At first I thought that just making mcedit to not display ^M if followed by \n would be enough, but turned out that I'd need to teach cursor to skip them too in various places, and that would be lot of effort to learn mcedit's internals and do it right in all places.

So I indeed went for the following solution:

1. On opening file, detect line-endings used by sampling some initial content.
2. If it happen to be CR or CRLF, skip fast load path, and in edit_insert_file() convert such line endings to \n.
3. Save detected line ending type for editor.

That's basicly all - alien text files are converted to unix on load, then converted vice-versa on save. Only extra thing needed on this stage was to make Save As to treat "don't change" as indeed don't change (to not reset auto-detected line ending type).

Patch is attached (note - debug output). I'd appreciate review for the approach. Then, further work might be:

1. Add config setting for auto-detect behavior.
2. Add UI option for this setting.
3. Optionally, on loading file with autodected line breaks, verify that all breaks indeed conform detected type, and otherwise warn user that one may have non-reversible data change.

[mc-butler]

Changed by pfalcon (pmiscml@….com) on Jan 6, 2011 at 22:03 UTC (comment 12.13)

Replying to pfalcon:

1. Add config setting for auto-detect behavior.
2. Add UI option for this setting.
3. Optionally, on loading file with autodected line breaks, verify that all breaks indeed conform detected type, and otherwise warn user that one may have non-reversible data change.

4. Display line endings used in status line.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 7, 2011 at 21:42 UTC (comment 13.14)

pfalcon:
ok, me like your patch.
1) can you create repo on github.com ?
2) i think no need add new param in edit_insert_file, just use edit->lb for this

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 7, 2011 at 23:46 UTC (comment 15)

branch: 1652_autodetect_lb