Release built artifacts on partial failure + fix CUDA/SYCL bridge compile - #44
Merged
Merged
Conversation
The `release` job used `needs: build` with no `if:`, so a single failed
matrix leg (currently the slow CUDA/SYCL source builds) skipped the whole
release — discarding the CPU, Vulkan, and macOS binaries that built fine
minutes earlier.
Add `if: ${{ !cancelled() }}` so the release job runs after the build
matrix regardless of individual failures, publishing whatever artifacts
were uploaded. Failed legs upload nothing and are simply absent from the
release. If every target failed (zero artifacts) the job errors instead
of cutting an empty release. The overall run still goes red when a target
fails, keeping the failure visible.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
After pinning the submodule to b9837 (#42), the CUDA and SYCL source builds compiled the full tree (~15 min) and then failed: autocommit_common_bridge.cpp:662: error: 'llama_params_fit' was not declared in this scope The bridge guarded llama_params_fit behind `#ifdef LLAMA_CPP_PREBUILT`, no-oping it for the binary release but still calling it from source. b9837 does not expose that public symbol in either mode — the fitting logic moved into libcommon's internal common/fit.cpp. Drop the source branch and no-op unconditionally, matching the prebuilt backends that already ship. Verified: the bridge compiles against b9837 in both modes (with and without -DLLAMA_CPP_PREBUILT). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make releases more resilient to partial build failures in the CI matrix and to fix a CUDA/SYCL source-build compilation break in the llama.cpp bridge code.
Changes:
- Update the Release workflow so the
releasejob runs even when somebuildmatrix legs fail, publishing whatever artifacts are available and failing only when none exist. - Remove/disable usage of
llama_params_fitin the CUDA/SYCL bridge to match the pinned llama.cpp release API surface and avoid compile errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/llama-sys/src/autocommit_common_bridge.cpp |
No-op autocommit_llama_params_fit unconditionally to avoid calling a missing symbol in source builds. |
.github/workflows/release.yml |
Make the release job tolerant of partial build failures and gate publishing on whether artifacts exist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ys() Addresses review feedback. !cancelled() does run when a needs leg fails (including a status function overrides Actions' implicit success() gate) and, unlike always(), still skips a manually cancelled run. No behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Two independent changes, both aimed at the CUDA/SYCL source builds that keep breaking full releases. The
v0.17.4release (run 28914476140) built CPU/Vulkan/macOS in ~2.5 min each, then CUDA/SYCL ran the full ~15-min build and failed at the very end — and because thereleasejob required all legs, the three good binaries were discarded.1.
ci(release)— publish what built, even if some targets failThe
releasejob usedneeds: buildwith noif:, so one failed matrix leg skipped the whole release. Now it runs withif: ${{ !cancelled() }}:This is the direct fix for "the long build always gets ruined by the 2 failed backends."
2.
fix(build)— the actual CUDA/SYCL failure (not OOM/timeout)The failure looked like it might be a resource issue, but it was another API mismatch surfacing only after the full build:
The bridge guarded
llama_params_fitbehind#ifdef LLAMA_CPP_PREBUILT— no-oping it for the binary release but still calling it in the#elsefrom-source branch. Since #42 pinned the submodule to b9837, the source build is also b9837, which doesn't expose that public symbol in either mode (the fitting logic moved into libcommon's internalcommon/fit.cpp). Fix: no-op unconditionally, matching the prebuilt backends that already ship (they've never run the fit either).Verification
release.ymlparses as valid YAML.-DLLAMA_CPP_PREBUILT— exactly what CUDA/SYCL do), and still compiles in prebuilt mode. This was the precise step that failed at line 662.Caveat: I can't run the CUDA/SYCL toolchains locally, so this fixes the confirmed compile error but I can't rule out a further issue at their link stage. That's exactly what change #1 now protects against — worst case, CPU/Vulkan/macOS still release.
After merge
Cut a
v0.17.5tag to exercise the full matrix. Expected: all five publish; if CUDA/SYCL still trip on something downstream, the other three release anyway.