Fix auto-fish connect unknown world crashing occur#6316
Open
aazz180 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Open
Fix auto-fish connect unknown world crashing occur#6316aazz180 wants to merge 1 commit intoMeteorDevelopment:masterfrom
aazz180 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
Fix crash when user joins a server and autofish tries to fish (because of a different module calls it, but it lags due to slow connection).
Contributor
Author
|
This PR is alike #6253 but for auto-fish instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash when user joins a server and autofish tries to fish (because of a different module calls it, but it lags due to slow connection).
Type of change
Description
Fixes a bug where if the auto fish module is called before the world loads, Meteor crashes. This can occur due to an addon calling the auto fish module before the world loads.
This PR fixes this bug and crash from my crash log.
Related issues
Mention any issues that this pr relates to.
How Has This Been Tested?
This PR has been tested on a singleplayer world and on the same condtions that the bug occured on in a mutli-player server (Minehut)
Checklist: