Skip to content

feat!: drop support for Node 18 and 20 - #324

Merged
cryptodev-2s merged 0 commit into
migrate/pr2i-esm-onlyfrom
migrate/pr2j-drop-node-18-20
Sep 8, 2026
Merged

feat!: drop support for Node 18 and 20#324
cryptodev-2s merged 0 commit into
migrate/pr2i-esm-onlyfrom
migrate/pr2j-drop-node-18-20

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Top of stack #315, on #323. Mirrors MetaMask/core#9976, the bottom of core's foundational stack.

Breaking

Before After
engines.node ^18.18 || ^20.14 || >=22 ^22.14.0 || ^24
CI matrix 18, 20, 22 22, 24

constraints.pro is updated to match, so yarn constraints enforces the new range.

Why this one before TypeScript and target/lib

Core sequenced its stack Node → ESM → TypeScript → target/lib, and that order is a dependency chain rather than an arbitrary grouping. Raising the runtime floor first is what justifies each step above it, and bumping the emit target is only defensible once the floor guarantees the runtime supports it.

The remaining two land in that order after this.


Note

Medium Risk
Breaking runtime contract for all consumers and CI; no application logic changes, but anyone on Node 18/20 must upgrade before adopting this release.

Overview
Breaking: This PR raises the minimum supported Node version and aligns CI with that floor, mirroring MetaMask/core’s foundational stack ordering.

engines.node is now ^22.14.0 || ^24 (Node 18 and 20 are no longer supported). The same range is enforced via constraints.pro, so yarn constraints keeps workspace packages consistent. GitHub Actions build-lint-test now runs on 22.x and 24.x instead of 18, 20, and 22. The unreleased CHANGELOG entry documents the breaking change.

Reviewed by Cursor Bugbot for commit a3e25e3. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security

socket-security Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​node@​18.18.14 ⏵ 22.20.1100 +121008196100

View full report

@cryptodev-2s
cryptodev-2s force-pushed the migrate/pr2j-drop-node-18-20 branch from 9118100 to 8f5fc35 Compare September 7, 2026 12:31
@cryptodev-2s
cryptodev-2s force-pushed the migrate/pr2j-drop-node-18-20 branch 2 times, most recently from 8f5fc35 to a3e25e3 Compare September 8, 2026 12:39
@cryptodev-2s
cryptodev-2s merged commit a3e25e3 into main Sep 8, 2026
@cryptodev-2s
cryptodev-2s deleted the migrate/pr2j-drop-node-18-20 branch September 8, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant