feat!: drop support for Node 18 and 20 - #324
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cryptodev-2s
force-pushed
the
migrate/pr2j-drop-node-18-20
branch
from
September 7, 2026 12:31
9118100 to
8f5fc35
Compare
cryptodev-2s
force-pushed
the
migrate/pr2j-drop-node-18-20
branch
2 times, most recently
from
September 8, 2026 12:39
8f5fc35 to
a3e25e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top of stack #315, on #323. Mirrors MetaMask/core#9976, the bottom of core's foundational stack.
Breaking
engines.node^18.18 || ^20.14 || >=22^22.14.0 || ^24constraints.prois updated to match, soyarn constraintsenforces the new range.Why this one before TypeScript and target/lib
Core sequenced its stack Node → ESM → TypeScript → target/lib, and that order is a dependency chain rather than an arbitrary grouping. Raising the runtime floor first is what justifies each step above it, and bumping the emit target is only defensible once the floor guarantees the runtime supports it.
The remaining two land in that order after this.
Note
Medium Risk
Breaking runtime contract for all consumers and CI; no application logic changes, but anyone on Node 18/20 must upgrade before adopting this release.
Overview
Breaking: This PR raises the minimum supported Node version and aligns CI with that floor, mirroring MetaMask/core’s foundational stack ordering.
engines.nodeis now^22.14.0 || ^24(Node 18 and 20 are no longer supported). The same range is enforced viaconstraints.pro, soyarn constraintskeeps workspace packages consistent. GitHub Actionsbuild-lint-testnow runs on 22.x and 24.x instead of 18, 20, and 22. The unreleased CHANGELOG entry documents the breaking change.Reviewed by Cursor Bugbot for commit a3e25e3. Bugbot is set up for automated code reviews on this repo. Configure here.