Skip to content

fix(ci): pass test-source-prefix for Appium Playwright health report (MMQA-2013) - #34188

Merged
cmd-ob merged 3 commits into
mainfrom
cursor/mmqa-2013-test-source-prefix-ebd2
Aug 3, 2026
Merged

cmd-ob merged 3 commits into
mainfrom
cursor/mmqa-2013-test-source-prefix-ebd2

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

Complements MetaMask/github-tools#274 (merged) for MMQA-2013.

Slack links from the Playwright Appium test health report were 404ing because Playwright reports paths relative to testDir (tests/smoke-appium), e.g. accounts/foo.spec.ts, while GitHub blob URLs need the repo-relative path.

This PR:

  1. Pins playwright-test-health-report to the merged github-tools main commit (a4a179a) that adds path normalization and the test-source-prefix input
  2. Passes test-source-prefix: tests/smoke-appium from .github/workflows/flaky-test-report.yml

Validation

Manual workflow_dispatch on this branch succeeded:
https://github.com/MetaMask/metamask-mobile/actions/runs/30814511794

That run used test-source-prefix: tests/smoke-appium against the pre-merge github-tools commit; pin was then retargeted to the merged main SHA (a4a179a).

Changelog

CHANGELOG entry: null

Related issues

Fixes: MMQA-2013
Refs: MetaMask/github-tools#274

Manual testing steps

Feature: Appium Playwright health report Slack links

  Scenario: workflow dispatch generates report with valid blob URLs
    Given MetaMask/github-tools#274 is merged on main
    And secrets for the Playwright health Slack webhook are configured

    When a maintainer runs workflow_dispatch on "Flaky test report" with job=appium
    Then the Slack report spec links resolve to files under tests/smoke-appium/
    And absolute CI paths under tests/ also resolve without 404s

Validated via workflow_dispatch: https://github.com/MetaMask/metamask-mobile/actions/runs/30814511794 (success).

Screenshots/Recordings

N/A — CI workflow / Slack link formatting only; no app UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web Open in Cursor 

Complement MetaMask/github-tools#274 (MMQA-2013): pin the Playwright
test health report action to the fix commit and set
test-source-prefix to tests/smoke-appium so Slack GitHub blob links
resolve for testDir-relative Appium smoke paths.

Co-authored-by: cmd-ob <cmd-ob@users.noreply.github.com>
@metamask-ci metamask-ci Bot added the team-qa QA team label Aug 3, 2026
@metamask-ci

metamask-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

github-tools#274 landed on main as a4a179a; retarget the Appium health
report action pin from the pre-merge PR commit.

Co-authored-by: cmd-ob <cmd-ob@users.noreply.github.com>
@cmd-ob
cmd-ob marked this pull request as ready for review August 3, 2026 12:52
@cmd-ob
cmd-ob requested a review from a team as a code owner August 3, 2026 12:52
Co-authored-by: cmd-ob <cmd-ob@users.noreply.github.com>
@cmd-ob
cmd-ob enabled auto-merge August 3, 2026 14:21
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@cmd-ob
cmd-ob added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit 61245b1 Aug 3, 2026
111 of 122 checks passed
@cmd-ob
cmd-ob deleted the cursor/mmqa-2013-test-source-prefix-ebd2 branch August 3, 2026 15:10
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 3, 2026
@metamask-ci metamask-ci Bot added the release-8.7.0 Issue or pull request that will be included in release 8.7.0 label Aug 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.7.0 Issue or pull request that will be included in release 8.7.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants