feat(identity): add ramps order Backup & Sync controls - #46044
Draft
georgeweiler wants to merge 1 commit into
Draft
feat(identity): add ramps order Backup & Sync controls#46044georgeweiler wants to merge 1 commit into
georgeweiler wants to merge 1 commit into
Conversation
georgeweiler
temporarily deployed
to
pr-comment
September 4, 2026 02:29 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (16 files, +328 -11)
👨🔧 @MetaMask/extension-platform (1 files, +2 -1)
📜 @MetaMask/policy-reviewers (8 files, +160 -24)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧪 @MetaMask/qa (2 files, +11 -1)
|
This was referenced Sep 4, 2026
georgeweiler
temporarily deployed
to
pr-comment
September 4, 2026 02:55 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [bab241c]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 5 warn · 🔴 4 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Cursor <cursoragent@cursor.com>
georgeweiler
force-pushed
the
feat/ramps-order-sync-settings
branch
from
September 9, 2026 09:21
bab241c to
fbc4e37
Compare
georgeweiler
had a problem deploying
to
pr-comment
September 9, 2026 09:21 — with
GitHub Actions
Error
GitHub Actions
Error
georgeweiler
temporarily deployed
to
pr-comment
September 9, 2026 09:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
georgeweiler
temporarily deployed
to
pr-comment
September 9, 2026 09:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [fbc4e37]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 8 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgeweiler
added this pull request to stack #46179
September 9, 2026 10:03
pull Bot
pushed a commit
to Reality2byte/metamask-extension
that referenced
this pull request
Sep 9, 2026
## **Description** Part 1 of 5 replacing MetaMask#44367. Local development sometimes needs DEV Profile Sync (for example staging ramps). Identity JWTs are shared by many `getBearerToken` consumers, so flipping every `yarn start` to DEV by default would mint DEV tokens against services that still talk to PRD. This follows the Mobile pattern: 1. Opt in with `MM_DEV_API_ENV=dev` in `.metamaskrc` (default remains prod). Restart `yarn start` after changing it. 2. A single source (`devApiEnv` / `loadAuthenticationConfig`) is used by AuthenticationController, User Storage, Profile Metrics, Config Registry, and Authenticated User Storage so those backends agree. 3. Settings → Debug → Backup and sync shows the current identity env and can clear the persisted auth session via `performSignOut` after you flip the flag. `FORCE_AUTH_MATCH_BUILD` is unchanged for beta/UAT. Notifications, shield, money-account, bridge, and perps stay on PRD in this PR. ## **Changelog** CHANGELOG entry: null ## **Related issues** Replaces part of MetaMask#44367. ## **Manual testing steps** 1. Leave `MM_DEV_API_ENV` unset and confirm Profile Sync still uses production (`oidc.api.cx.metamask.io`). 2. Set `MM_DEV_API_ENV=dev` in `.metamaskrc` and restart `yarn start`. 3. Open Settings → Debug → Backup and sync, confirm the identity env shows `dev`, and click Clear auth session. 4. Unlock / sign in to Backup & Sync and confirm Network requests go to `oidc.dev-api.cx.metamask.io`. 5. Unset the flag, restart, clear the session again, and confirm production identity is restored. <!-- ## **Screenshots/Recordings** ### **Before** ### **After** --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- Stack: MetaMask#46042 → MetaMask#46043 → MetaMask#46044 → MetaMask#46045 → MetaMask#46046 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes authentication environment selection and JWT/backend alignment for Backup & Sync and related identity services; misconfiguration could break sign-in until the session is cleared. > > **Overview** > Adds an **opt-in local dev switch** (`MM_DEV_API_ENV=dev` in `.metamaskrc`) so Profile Sync identity stays on **prod by default** during `yarn start`, avoiding DEV JWTs against services that still use PRD. > > **`devApiEnv()`** and updated **`loadAuthenticationConfig()`** centralize env selection: DEV only when development build + explicit flag; **`FORCE_AUTH_MATCH_BUILD`** still maps beta/uat to UAT; non-local builds ignore the flag. **Authenticated User Storage** init now maps **`Env.DEV`** → `dev` so it stays aligned with auth JWT env. > > **Settings → Debug → Backup and sync** shows the active identity env and adds **Clear auth session** (`performSignOut`) for after flipping the flag. Docs/build defaults (`builds.yml`, `.metamaskrc.dist`) and unit tests cover the new behavior. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e68779f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 3 of 5 replacing #44367. Stacked on #46043.
Adds Buy & sell orders to the Backup & Sync settings, including selectors, parent-toggle cascading, persisted state typing, and identity test fixtures. When the wallet unlocks, the identity provider requests a ramps order sync only when onboarding, authentication, external-services, Backup & Sync, and ramps-sync gates all pass.
This slice also adopts the final Profile Sync preview from MetaMask/core#9474. That preview replaces Snap keyring access with
KeyringController:withKeyringV2Unsafe, so the identity messengers and generated LavaMoat policies are updated atomically.Primary ownership is
@MetaMask/accounts-engineers; the small E2E fixture/page-object changes additionally involve@MetaMask/qaand@MetaMask/extension-platform.Changelog
CHANGELOG entry: Added Backup & Sync support for buy and sell order history
Related issues
Depends on #46043 and MetaMask/core#9474.
Replaces part of #44367.
Manual testing steps
RampsController.orders.Pre-merge author checklist
Pre-merge reviewer checklist
Stack: #46042 → #46043 → #46044 → #46045 → #46046