Conversation
…mples ## Problem The `signer.getAddress()` method in ethers v6 returns a `Promise<string>`, but examples in `embedded-wallets/connect-blockchain/_react-native-connect-blockchain/_evm-get-account.mdx` and `_evm-get-balance.mdx` (line 11) were missing await. ## Fix Added: `await` before `signer.getAddress()`
|
@leonschh is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
signer.getAddress()method in ethers v6 returns aPromise<string>, but examples inembedded-wallets/connect-blockchain/_react-native-connect-blockchain/_evm-get-account.mdxwere missingawait.Fix
Added:
awaitbeforesigner.getAddress()Note
Low Risk
Documentation-only change to an embedded-wallets code sample; no runtime or auth logic is modified.
Overview
Updates the React Native EVM get account doc snippet so it matches ethers v6, where
signer.getAddress()returns aPromise<string>.The example now uses
await signer.getAddress()(consistent with the existingawait ethersProvider.getSigner()line) so copied code resolves the address instead of logging a Promise.Reviewed by Cursor Bugbot for commit acc7ecf. Bugbot is set up for automated code reviews on this repo. Configure here.