feat(bitcoin-wallet-snap): add batch proof-of-ownership signing - #266
Open
hmalik88 wants to merge 11 commits into
Open
feat(bitcoin-wallet-snap): add batch proof-of-ownership signing#266hmalik88 wants to merge 11 commits into
hmalik88 wants to merge 11 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # packages/bitcoin-wallet-snap/snap.manifest.json
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds
signProofOfOwnershipBatchsupport to the Bitcoin Wallet Snap.The new method lets MetaMask request proof-of-ownership signatures for multiple Bitcoin accounts in one Snap RPC call. The response preserves input order and returns per-item success/error results, so one invalid account or message does not fail the entire batch.
References
N/A
Checklist