Fix dev-only lint errors in product-safety packages - #10163
Merged
Conversation
Currently, there are some type errors that exist in packages owned by `@MetaMask/product-safety`. These type errors are not present in production code, so they are not flagged by `yarn build`, but they _will_ be flagged soon by `yarn lint:tsc`, and so we need to fix them.
Collaborator
Author
|
Adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, there are some type errors that exist in packages owned by
@MetaMask/product-safety. These type errors are not present in production code, so they are not flagged byyarn build, but they will be flagged soon byyarn lint:tsc, and so we need to fix them.References
https://consensyssoftware.atlassian.net/browse/WPC-1275
Checklist
Note
Low Risk
Test-only type fixes with no runtime or production code changes.
Overview
Updates phishing-controller test helpers so they match current controller state typings ahead of stricter
yarn lint:tscchecks—no production behavior changes.Mock
TransactionControllerStateobjects now includebatchTransactionCounts: {}ingetDefaultTransactionControllerStateandcreateMockStateChangePayload, matching the field added onTransactionController.The address-book integration test now publishes
AddressBookController:stateChangewith an empty[]patches argument as the second parameter, fixing the messenger event signature.Reviewed by Cursor Bugbot for commit 510410e. Bugbot is set up for automated code reviews on this repo. Configure here.