Skip to content

Fix dev-only lint errors in product-safety packages - #10163

Merged
mcmire merged 1 commit into
mainfrom
fix-lint-errors/product-safety-team
Sep 9, 2026
Merged

Fix dev-only lint errors in product-safety packages#10163
mcmire merged 1 commit into
mainfrom
fix-lint-errors/product-safety-team

Conversation

@mcmire

@mcmire mcmire commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Explanation

Currently, there are some type errors that exist in packages owned by @MetaMask/product-safety. These type errors are not present in production code, so they are not flagged by yarn build, but they will be flagged soon by yarn lint:tsc, and so we need to fix them.

References

https://consensyssoftware.atlassian.net/browse/WPC-1275

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only type fixes with no runtime or production code changes.

Overview
Updates phishing-controller test helpers so they match current controller state typings ahead of stricter yarn lint:tsc checks—no production behavior changes.

Mock TransactionControllerState objects now include batchTransactionCounts: {} in getDefaultTransactionControllerState and createMockStateChangePayload, matching the field added on TransactionController.

The address-book integration test now publishes AddressBookController:stateChange with an empty [] patches argument as the second parameter, fixing the messenger event signature.

Reviewed by Cursor Bugbot for commit 510410e. Bugbot is set up for automated code reviews on this repo. Configure here.

Currently, there are some type errors that exist in packages owned by
`@MetaMask/product-safety`. These type errors are not present in
production code, so they are not flagged by `yarn build`, but they
_will_ be flagged soon by `yarn lint:tsc`, and so we need to fix them.
@mcmire

mcmire commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Adding no-changelog because there are no changes to production code.

@mcmire
mcmire marked this pull request as ready for review September 9, 2026 21:50
@mcmire
mcmire requested a review from a team as a code owner September 9, 2026 21:50
@mcmire
mcmire deployed to default-branch September 9, 2026 21:50 — with GitHub Actions Active

@adonesky1 adonesky1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmire
mcmire added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit acf1f0c Sep 9, 2026
67 of 68 checks passed
@mcmire
mcmire deleted the fix-lint-errors/product-safety-team branch September 9, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants