feat(kyc-controller): Add fetchSessionDisclaimers to KycController. Rename relevant KycService methods - #10162
Merged
jiexi merged 9 commits intoSep 9, 2026
Conversation
…d fetchSessionDisclaimers to fetchSessionDisclaimersBySessionId
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
Signed-off-by: Sébastien Van Eyck <sebastien.vaneyck@consensys.net>
…aimers-from-controller
…ession-disclaimers-from-controller' into jl/kyc-controller-expose-fetch-session-disclaimers-from-controller
jiexi
enabled auto-merge
September 9, 2026 22:25
jiexi
deleted the
jl/kyc-controller-expose-fetch-session-disclaimers-from-controller
branch
September 9, 2026 22:28
Akaryatrh
restored the
jl/kyc-controller-expose-fetch-session-disclaimers-from-controller
branch
September 10, 2026 09:42
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
fetchDisclaimersCatalogtofetchSessionDisclaimersByCountryin KycServicefetchSessionDisclaimerstofetchSessionDisclaimersBySessionIdin KycServicefetchSessionDisclaimersto KycController which takes eithercountryorsessionIdparams and calls the relevant underlying KycService methodReferences
See: MetaMask/metamask-mobile#35924
Checklist
Note
Medium Risk
Breaking renames on KycService/messenger actions require consumer updates; the new controller API touches session disclaimer/consent state on the KYC path.
Overview
Adds
KycController.fetchSessionDisclaimers, a messenger-exposed entry point that loads the idOS + KYC-provider disclaimer catalog by either{ sessionId }(session-scoped, with consent flags) or{ country }(global catalog). Session fetches also update controllersessionDisclaimers, with the existing flow-generation guard so areset()during the request does not write stale state.Breaking renames on
KycService(and matching messenger actions / exported param types):fetchDisclaimersCatalog→fetchSessionDisclaimersByCountry, andfetchSessionDisclaimers→fetchSessionDisclaimersBySessionId. Internal consent recording (#recordSessionDisclaimers) now calls the session-id action. Docs, changelog, exports, and tests follow the new names.Reviewed by Cursor Bugbot for commit 97d6b86. Bugbot is set up for automated code reviews on this repo. Configure here.