Release 1247.0.0 - #10155
Conversation
|
Warning MetaMask internal reviewing guidelines:
|
This comment has been minimized.
This comment has been minimized.
mcmire
left a comment
There was a problem hiding this comment.
Some questions below on packages that we're bumping from an 0.x version to 1.0.0 version.
de2f5ae to
36a54c8
Compare
|
@metamaskbot update-changelogs |
|
✅ Changelogs updated and pushed. |
Reverts #10155. The release workflow didn't trigger. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Wide dependency and semver rollback across the monorepo can desync consumers that already picked up 1247.0.0 packages until a successful re-release; runtime behavior is unchanged but install graphs and published versions need careful coordination. > > **Overview** > Reverts the **1247.0.0** release from #10155 because the release workflow did not run. This rolls the repo back to the pre-release state without changing controller or service implementation code. > > The monorepo root version moves from **1247.0.0** to **1246.0.0**, and **package versions are downgraded** across many `@metamask/*` packages (for example `@metamask/base-controller` 10→9.1.0, `@metamask/messenger` 3→2.x, `@metamask/network-controller` 37→36, and similar cascades through accounts, assets, bridge, transaction, and related packages). > > **Inter-package dependency ranges** in `package.json` files are aligned with those older versions, and root devDependencies such as `@metamask/eth-block-tracker`, `@metamask/json-rpc-engine`, and `@metamask/network-controller` are stepped back as well. **Changelogs** drop the new major/minor release sections that #10155 added, fold those notes back under `[Unreleased]` where applicable, and fix version compare links at the bottom of each file. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit cd89c0d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Explanation Recreated MetaMask#10155 after reverting in MetaMask#10159. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Monorepo-wide major releases and breaking platform requirements (ESM, Node 22) force coordinated client upgrades; misaligned versions can break messenger/controller wiring at runtime. > > **Overview** > Publishes **1247.0.0** of `@metamask/core-monorepo` by cutting new major (or milestone) versions across many workspace packages and aligning their `package.json` dependency ranges. > > The release mostly **finalizes changelog entries** that were sitting under `[Unreleased]`—especially **ESM-only**, **Node.js 22+**, and **ES2022** build targets—while adding **MetaMask#10160** dependency bumps such as `@metamask/messenger` **^3**, `@metamask/base-controller` **^10**, `@metamask/network-controller` **^37**, `@metamask/transaction-controller` **^70**, and `@metamask/controller-utils` **^13**. Heavily connected packages (e.g. `assets-controller`, `assets-controllers`, `bridge-controller`, `core-backend`) get matching semver bumps so the graph stays consistent. > > The root `package.json` also bumps workspace dev dependencies on `@metamask/eth-block-tracker`, `@metamask/eth-json-rpc-provider`, `@metamask/json-rpc-engine`, and `@metamask/network-controller`. **No application/controller source changes** appear in this diff—only versions, changelogs, and dependency pins. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ffecd7b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Explanation
This is the release candidate for version
1247.0.0.References
Checklist
Note
Medium Risk
Wide major-version alignment across account, keyring, network, transaction, and messenger packages forces MetaMask clients to upgrade in lockstep; runtime risk is low here because the PR is versioning/changelog-only, but consumer breakage from semver is significant.
Overview
This PR cuts release candidate
1247.0.0for the core monorepo by bumping the root version and publishing new versions across a large set of@metamask/*packages.Most package releases are major bumps that finalize what was under
[Unreleased]: ESM-only, Node.js 22+, and ES2022 output, plus coordinated dependency updates from #10155. Internal versions are aligned on shared infrastructure such as@metamask/base-controller^10,@metamask/messenger^3,@metamask/network-controller^37,@metamask/transaction-controller^70,@metamask/keyring-controller^28, and@metamask/controller-utils^13, with downstream controllers (assets, bridge, accounts, etc.) bumped to match.The root
package.jsonalso updates dev tooling deps (eth-block-tracker,eth-json-rpc-provider,json-rpc-engine,network-controller). Changes arepackage.json/CHANGELOG.mdonly in the diff shown—no controller implementation changes in this release PR.Reviewed by Cursor Bugbot for commit 35836ec. Bugbot is set up for automated code reviews on this repo. Configure here.