fix: reopen StoreAdapterWeb IndexedDB after force-close - #346
Open
Cal-L wants to merge 2 commits into
Open
Conversation
Invalidate the cached IDB handle on close/versionchange and retry get/set/delete once after InvalidStateError or UnknownError so WKWebView and Safari recover without a reload. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/connect-multichainStoreAdapterWebafter Safari/WKWebView force-closes IndexedDB by invalidating the cached handle onclose/versionchangeand retryingget/set/deleteonce onInvalidStateErrororUnknownError.StoreAdapterRN(AsyncStorage) unchanged. Customstorageoverrides are unaffected.1.2.1.Test plan
yarn workspace @metamask/connect-multichain test src/store/index.test.ts(76 tests)1.2.1to npmMade with Cursor