Skip to content

Implement a sub-band weighted UV-index diagnostic - #45

Open
James Manners (mo-jmanners) wants to merge 5 commits into
MetOffice:mainfrom
mo-jmanners:42_uvindex
Open

James Manners (mo-jmanners) wants to merge 5 commits into
MetOffice:mainfrom
mo-jmanners:42_uvindex

Conversation

@mo-jmanners

@mo-jmanners James Manners (mo-jmanners) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

PR Summary

Implement a sub-band weighted UV-index diagnostic

Sci/Tech Reviewer: Dr Stephan Havemann (@Petzi1)
Code Reviewer:

UV-index diagnostics are added for the entire profile (in channels) and for the surface (broadband integrated):

  • After the spectral file is read in socrates_set_spectrum, a new routine is called to weight the sub-bands with the erythemal action spectrum: set_weight_uv_index
  • In augment_channel_mod the UV-index diagnostics are incremented by applying this weighting to the sub-band fluxes.
  • In augment_radiance the surface UV-index diagnostics are incremented.
  • Other code changes facilitate the output of the diagnostics from the l_run_cdf offline driver.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings

Testing

  • If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

The diagnostics are currently only output by the offline l_run_cdf driver. Further LFRic / UM code changes will be needed to output the diagnostics there.

Socrates stand-alone testing

[~/git/socrates_admin/examples](42_uvindex +%=):$ ./quick_tests 
Testing code compiled in /home/users/james.manners/git/socrates_admin/bin
---
Testing simple calls to the runes interface:
Matched gfortran output
OK
---
Testing the runes_nc driver using LFRic diagnostic input:
Matched SW output
Matched LW output
OK
---
Testing raw_input to convert column data into input files:
OK
---
Testing Cl_run_cdl for ICRCCM case 27 (LW) on AER profiles:
OK
---
Testing Cl_run_cdf on multiple profiles:
OK
---
Test Cl_run_cdf for CIRC case 6
(HadGEM, GA7, SES and 300/260 band spectral files):
OK
---
Testing pseudo-spherical geometry code:
Calculating zenith angles:  75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
OK
---
Testing photolysis and non-LTE code:
Mapping sub-bands to channels.
Matched gfortran output
OK
---
Test McICA code (create mcica_data file and run on CRM profile):
OK
---
Testing creation of aerosol properties for a spectral file:
Running scatter_90...
Running scatter_average_90...
Running prep_spec...
Matched gfortran12 output
OK
---
Testing generating and running with prescribed optical properties:
Running raw_input...
Running Cscatter... please wait...
Running Cscatter... please wait...
Running Cscatter_average...
Running Cscatter_average...
Running prep_opt_profile...
Running Cl_run_cdl...
All done.
OK
---
Testing Crun_mono to calculate radiances:
Matched ref output
OK
---
Testing Ccorr_k to generate correlated-k coefficients:
Matched gfortran12 output
OK
---
Testing flexchem chemistry:
Matched KGO output
OK
---
Testing CDL scripts:
OK
---
All passed.

UM trac.log

1 UM failure concerning NVIDIA build in STABLE. Failure not connected to this ticket.

Test Suite Results - um - um_socrates42_uvindex/run2

Suite Information

Item Value
Suite Name um_socrates42_uvindex/run2
Suite User james.manners
Workflow Start 2026-10-20T17:23:38
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.07.1 True
jules MetOffice/jules@2026.07.1 True
moci MetOffice/moci@2026.07.1 True
mule MetOffice/mule@2026.07.1 True
shumlib MetOffice/shumlib@2026.07.1 True
socrates mo-jmanners/socrates@42_uvindex True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True
ukca MetOffice/ukca@2026.07.1 True
um mo-jmanners/um@9c139d0 True
um_aux MetOffice/um_aux@2026.07.1 True
um_meta MetOffice/um_meta@2026.07.1 True

Approvals

Code Owners

  • No UM Code Owners Required

Config Owners

No UM Config Owners Required

Task Information

❌ failed tasks - 1
Task State
fcm_make_ex1a_nvidia_um_safe_omp failed
✅ succeeded tasks - 879
⌛ waiting tasks - 5
Task State
housekeep_azspice waiting
housekeep_ex1a waiting
recon-ex1a_nvidia_um_safe_omp-n48_ga_amip_exp_2day-2x4-1t waiting
recon-ex1a_nvidia_um_safe_omp-n48_ga_amip_exp_2day-4x2-1t waiting
script_azspice_compiler_warning_checker waiting

LFRic Apps trac.log

1 LFRic Apps failure using HEAD of LFRic Apps trunk. Failure not related to this ticket.

Test Suite Results - lfric_apps - lfric_apps_socrates42_uvindex/run1

Suite Information

Item Value
Suite Name lfric_apps_socrates42_uvindex/run1
Suite User james.manners
Workflow Start 2026-10-20T15:06:26
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@996db30 True
jules MetOffice/jules@332ca85 True
lfric_apps mo-jmanners/lfric_apps@68d11eb True
lfric_core MetOffice/lfric_core@601094b True
moci MetOffice/moci@2026.07.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@77a5166 True
socrates mo-jmanners/socrates@42_uvindex True
socrates-spectral MetOffice/socrates-spectral@2026.07.1 True
ukca MetOffice/ukca@c372b36 True

Task Information

❌ failed tasks - 1
Task State
run_lfric_atm_clim_gc6-C48_MG_ex1a_cce_coupled-fast-debug-32bit-crun0 failed
✅ succeeded tasks - 1243
⌛ waiting tasks - 2
Task State
check_lfric_atm_clim_gc6-C48_MG_ex1a_cce_coupled-fast-debug-32bit-nrun-v-crun waiting
housekeep_ex1a waiting

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a sub-band weighted UV-index diagnostic

2 participants