Repository navigation
Implement a sub-band weighted UV-index diagnostic - #45
Open
James Manners (mo-jmanners) wants to merge 5 commits into
Open
James Manners (mo-jmanners) wants to merge 5 commits into
James Manners (mo-jmanners) wants to merge 5 commits into
Conversation
…n spectrum with sub-band fluxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Implement a sub-band weighted UV-index diagnostic
Sci/Tech Reviewer: Dr Stephan Havemann (@Petzi1)
Code Reviewer:
UV-index diagnostics are added for the entire profile (in channels) and for the surface (broadband integrated):
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
Testing
The diagnostics are currently only output by the offline l_run_cdf driver. Further LFRic / UM code changes will be needed to output the diagnostics there.
Socrates stand-alone testing
UM trac.log
1 UM failure concerning NVIDIA build in STABLE. Failure not connected to this ticket.
Test Suite Results - um - um_socrates42_uvindex/run2
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
❌ failed tasks - 1
⌛ waiting tasks - 5
LFRic Apps trac.log
1 LFRic Apps failure using HEAD of LFRic Apps trunk. Failure not related to this ticket.
Test Suite Results - lfric_apps - lfric_apps_socrates42_uvindex/run1
Suite Information
Task Information
❌ failed tasks - 1
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review