Skip to content

Migrate to XIOS 3 - #472

Draft
Ed Hone (EdHone) wants to merge 21 commits into
MetOffice:mainfrom
EdHone:main-xios3adopt
Draft

Ed Hone (EdHone) wants to merge 21 commits into
MetOffice:mainfrom
EdHone:main-xios3adopt

Conversation

@EdHone

@EdHone Ed Hone (EdHone) commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

The current iteration of XIOS 2 used by all the LFRic applications is no longer in development and will not be able to provide the I/O capability we will need going into the future. This PR migrates our applications to use an up-to-date version of XIOS 3. These changes will not be backwards compatible with the previous XIOS version.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

mo-marqh and others added 9 commits September 22, 2026 10:28
…jedi-lfric tests for XIOS3) (MetOffice#5)

* Add a means for jedi-lfric test code to call xios_context_finalize() directly

* Fix silly error

* Debugging - revert later

* Removing debug statements

* Adding myself to Contributors file

* Move context closure inside the check for projected coordinates (required
for lfric inputs tests to run with XIOS3). Unlikely to be backwards-compatible
with XIOS2
…projected_coordinates

as it is needed for coupled and lfric_atm test suite jobs to run with XIOS3
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Sep 22, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Hello Ed Hone (@EdHone)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants