Repository navigation
Enable the use of layered CF output for checkpoint-restart #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
89dbe7f
Massive overhaul of legacy/ugrid config
EdHone d9cc8a1
Complete changes and test output with io_demo
EdHone e4df51d
Add i index usage to W2 fs
EdHone 0cb09c7
Fix bench test and metafile
EdHone 1648a89
Fix issues with file def
EdHone bfd72c3
Fix metafile implementation
EdHone f717fa6
Tidy branch
EdHone aed8f63
Merge branch 'main' into ugrid-ckp-flag
EdHone c15c176
default to ugrid
EdHone b5b44dc
Correct setting of default convention to UGRID
EdHone 5cc67b5
Merge branch 'main' into ugrid-ckp-flag
EdHone 6857771
Fix file definition for temporal
EdHone ec913d1
Merge branch 'main' into ugrid-ckp-flag
EdHone 62bd835
Merge branch 'main' into ugrid-ckp-flag
EdHone 6f1ea9b
Comments from code review
EdHone 31bd3cf
Merge branch 'main' into ugrid-ckp-flag
EdHone 5ce2943
Merge branch 'main' into ugrid-ckp-flag
EdHone a7c7d96
Fix integration tests
EdHone b4375e2
Merge branch 'main' into ugrid-ckp-flag
svadams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise that it's unlikely that these if-tests wouldn't catch all cases, but it would still be good to have an
elseoption to catch any potential errors, rather than let the code continue without setting the file convention.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a confusing bit of code, but there's a reason why we can't include an
elsecondition. This bit of logic is essentially setting some object attributes after the constructor, based on XIOS configuration. The way the logic is constructed it takes the value in theiodef.xmlfile if it is set, then the value from the object if it's not set, and then finally defaults to UGRID if nothing is set.As I write this I realise that this logic is slightly all over the place, we probably shouldn't be changing the object's attribute after it's been set in the constructor so I will restructure it slightly to more accurately reflect the desired behaviour