Repository navigation
Further PSyclone pass of BL scripts - #828
Open
Benjamin Went (MetBenjaminWent) wants to merge 11 commits into
Open
Benjamin Went (MetBenjaminWent) wants to merge 11 commits into
Benjamin Went (MetBenjaminWent) wants to merge 11 commits into
Conversation
…as it can be done at the start making PSyclone's life a bit simpler and the code safer to Transform
Contributor
Author
|
User time (seconds): 261.30 |
Contributor
Author
Benjamin Went (MetBenjaminWent)
marked this pull request as ready for review
September 30, 2026 14:52
Matthew Hambley (MatthewHambley)
approved these changes
Oct 12, 2026
Matthew Hambley (MatthewHambley)
left a comment
Contributor
There was a problem hiding this comment.
Code owner (build system) review: Change just adds to an existing list in the fashion already established.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been improvments to PSyclone which allow us to more easily 'Transmute' physics source.
The maximal parallel transformation created by STFC has already been added to the local script for the boundary layer, however some of the larger or complex files are relying their origonal OMP in source.
This PR updates those.
This changeset extends the PSyclone CPU coverage, with 3x exceptions still:
Despite some changes in how the OMP is placed in the files by the Transformations (The number of parallel sections in bl_expl2 has gone up for example), the perfomance impact at both the alg and higher is negligable, meaning these scripts are sufficient automatic coverage of the source.
PR Summary
Sci/Tech Reviewer: Hacka Fett (@christophermaynard)
Code Reviewer:
Issue: #833
Umbrella Issue: #758
Top Umbrella: #106
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - bdylyr_psyclone_further_1/run12
Suite Information
Test Suite Results - lfric_apps - bdylyr_psyclone_further_1/run13
Suite Information
Task Information
❌ failed tasks - 2
Task Information
✅ succeeded tasks - 51
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review