Repository navigation
Nearest neighbour regrid in lfric2um - #806
James Bruten (james-bruten-mo) merged 20 commits into
Conversation
|
This ticket uses the kgo file from the C48 um2lfric nwp_gal9 job as the start dump: As the kgo lives on azspice and not ex1a, the ex1a trac.log has been generated with the equivalent kgo file that is used by the ex1a tasks, hence the separate trac.logs |
…lfric2um regrid weights
Steve Mullerworth (stevemullerworth)
left a comment
There was a problem hiding this comment.
Please provide a slightly more comprehensive description of the change in the PR template.
Implementation is in line with existing code, so sci/tech all OK subject to feedback being dealt with. I believe my role is to provide a tech, more than sci, review as the scientific result is not the final answer and subject to further change (it would be good for the PR description to discuss these aspects).
Spotted one minor spelling error while going through the change.
Steve Mullerworth (stevemullerworth)
left a comment
There was a problem hiding this comment.
Now approved
allynt
left a comment
There was a problem hiding this comment.
Code looks good. Just have a couple of questions.
|
Changed log level - also reordered task defs in |
allynt
left a comment
There was a problem hiding this comment.
My concerns have been addressed. This looks good to me.
ee14f75
into
MetOffice:main


PR Summary
This ticket will need a new file added to
$BIG_DATA_DIRIt will also add a new lfric2um kgo set
Sci/Tech Reviewer: Steve Mullerworth (@stevemullerworth)
Code Reviewer: allynt
This PR adds to LFRic2UM the functionality to regrid by the nearest neighbour method (as opposed to bilinear interpolation). I have set it up so that all fields that have a land-sea mask use this method for the moment, until such time as functionality for masked regridding is implemented [link to PR to go here].
The stashcodes for the relevant fields (and their respective lfric names) are
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - t806_nearest_neighbour/run12
Suite Information
Task Information
❌ failed tasks - 2
⌛ waiting tasks - 1
Suite Information
Task Information
❌ failed tasks - 2
⌛ waiting tasks - 1
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review