Skip to content

Multidata/pseudo-level field infrastructure for LFRic2UM - #678

Closed
Lottie Turner (mo-lottieturner) wants to merge 2 commits into
MetOffice:mainfrom
mo-lottieturner:lfric2um_multidata_infrastructure
Closed

Lottie Turner (mo-lottieturner) wants to merge 2 commits into
MetOffice:mainfrom
mo-lottieturner:lfric2um_multidata_infrastructure

Conversation

@mo-lottieturner

Copy link
Copy Markdown
Contributor

PR Summary

This ticket pulls out the basic infrastructure changes from #435 and #266 and (with error messages where the functionality added by those changes goes) pulls it into a separate PR that should not change any KGOs so that various work can build off it without having to start from scratch (and also to get it on sooner, as #435 needs land-sea masking for the new kgos to be valid, and #266 is still ironing out issues but further work from #564 requires some of this)

Sci/Tech Reviewer:
Code Reviewer:

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@mo-lottieturner Lottie Turner (mo-lottieturner) added the LFRic Inputs Changes by/affecting the LFRic Inputs project, including lfric2lfric, lfric2um, scintelapi, um2lfric label Jul 29, 2026
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Jul 29, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Hello Lottie Turner (@mo-lottieturner)!

Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR.

Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up.

@mo-lottieturner
Lottie Turner (mo-lottieturner) deleted the lfric2um_multidata_infrastructure branch September 30, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-modified The CLA has been modified as part of this PR - added by GA LFRic Inputs Changes by/affecting the LFRic Inputs project, including lfric2lfric, lfric2um, scintelapi, um2lfric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants